From: ykk@rock-chips•com (Yakir Yang)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC PATCH v2 4/4] dt-bindings: add document for rk3229-hdmi
Date: Mon, 11 Jan 2016 11:48:15 +0800 [thread overview]
Message-ID: <569325FF.10902@rock-chips.com> (raw)
In-Reply-To: <20160111020618.GA20680@rob-hp-laptop>
Hi Rob,
On 01/11/2016 10:06 AM, Rob Herring wrote:
> On Thu, Jan 07, 2016 at 05:05:11PM +0800, Yakir Yang wrote:
>> Signed-off-by: Yakir Yang <ykk@rock-chips•com>
>> ---
>> Changes in v2: None
>>
>> .../devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt
>> index 668091f..1cdc627 100644
>> --- a/Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt
>> +++ b/Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt
>> @@ -2,7 +2,7 @@ Rockchip specific extensions to the Synopsys Designware HDMI
>> ================================
>>
>> Required properties:
>> -- compatible: "rockchip,rk3288-dw-hdmi";
>> +- compatible: "rockchip,rk3288-dw-hdmi", "rockchip,rk3229-dw-hdmi";
>> - reg: Physical base address and length of the controller's registers.
>> - clocks: phandle to hdmi iahb and isfr clocks.
>> - clock-names: should be "iahb" "isfr"
>> @@ -15,8 +15,10 @@ Required properties:
>> rk3288 platform
>>
>> Optional properties
>> +- reg: Physical base address and length of the external HDMI PHY's registers.
> This is already required...
>
The original reg only include the DW HDMI controller registers:
reg = <0x200a0000 0x20000>;
But for now, I need to pass the external HDMI PHY registers:
reg = <0x200a0000 0x20000>, <0x12030000 0x10000>;
>> - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing
>> - clocks, clock-names: phandle to the HDMI CEC clock, name should be "cec"
>> + phandle to the external HDMI PHY clock, name should be "extphy"
> Does this change apply to rk3288 or just rk3229? If the latter, you
> should make that clear. The driver needs to allow for old dtb's that
> only have 1 clock.
It's the latter one, driver have allowed that by judging the device type,
but I should make the document more clear.
> Based on Philipp's feedback, you also need to add a phys property.
Yes, I'm preparing the new patches that create a new separate phy
driver for external HDMI phy, there would be much difference from
this version.
Thanks for your respond,
- Yakir
>
> Rob
>
>
>
prev parent reply other threads:[~2016-01-11 3:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 8:53 [RFC PATCH v2 0/4] Add RK3229 HDMI support Yakir Yang
2016-01-07 8:57 ` [RFC PATCH v2 1/4] drm: dw-hdmi: make it easy to recovery the platform data for platform driver Yakir Yang
2016-01-07 9:00 ` [RFC PATCH v2 2/4] drm: dw-hdmi: passing the "plat_data" when calling platform mode_valid Yakir Yang
2016-01-07 9:02 ` [RFC PATCH v2 3/4] drm: rockchip: hdmi: add RK3229 HDMI support Yakir Yang
2016-01-07 10:04 ` Philipp Zabel
2016-01-07 10:15 ` Yakir Yang
2016-01-07 16:50 ` Philipp Zabel
2016-01-08 9:13 ` Yakir Yang
2016-01-07 9:05 ` [RFC PATCH v2 4/4] dt-bindings: add document for rk3229-hdmi Yakir Yang
2016-01-11 2:06 ` Rob Herring
2016-01-11 3:48 ` Yakir Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569325FF.10902@rock-chips.com \
--to=ykk@rock-chips$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox