From: brijesh.singh@amd•com (Brijesh Singh)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ata: add AMD Seattle platform driver
Date: Mon, 11 Jan 2016 10:55:54 -0600 [thread overview]
Message-ID: <5693DE9A.9070101@amd.com> (raw)
In-Reply-To: <5693CB41.70408@redhat.com>
Hi,
On 01/11/2016 09:33 AM, Mark Langsdorf wrote:
> On 01/08/2016 04:21 PM, Brijesh Singh wrote:
>>
>> libata-*.c implements the "Enclosure management" style led messages but also has hooks
>> to register a custom led control callback. Since Seattle platform does not support
>> the "Enclosure management" registers hence ata_port_info we are setting a ATA_FLAG_EM | ATA_FLAG_SW_ACIVITY
>> to indicate that we can still handle the led messages by our registered callback. I see
>> that sata_highbank driver is doing something similar.
>
> The sata_highbank driver is doing it wrong and shouldn't have been
> accepted in its current condition. Enclosure management really should
> be a separate device. Please don't use it as an example.
>
Okay. Thanks for letting me know.
Should I consider extending the generic driver to handle this Seattle platform specific feature or go with a new
platform driver approach (i.e the one I am doing right now) ?
-Brijesh
next prev parent reply other threads:[~2016-01-11 16:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 20:53 [PATCH] ata: add AMD Seattle platform driver Brijesh Singh
2016-01-07 21:25 ` Arnd Bergmann
2016-01-07 22:24 ` Brijesh Singh
2016-01-07 23:42 ` Arnd Bergmann
2016-01-08 1:46 ` Brijesh Singh
2016-01-08 8:46 ` Arnd Bergmann
2016-01-08 22:21 ` Brijesh Singh
2016-01-08 22:47 ` Arnd Bergmann
2016-01-11 18:56 ` Brijesh Singh
2016-01-12 14:24 ` Arnd Bergmann
2016-01-13 16:55 ` Brijesh Singh
2016-01-13 20:39 ` Arnd Bergmann
2016-01-11 15:33 ` Mark Langsdorf
2016-01-11 16:55 ` Brijesh Singh [this message]
2016-01-07 22:56 ` Rob Herring
2016-01-08 19:59 ` Joe Perches
2016-01-11 10:23 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5693DE9A.9070101@amd.com \
--to=brijesh.singh@amd$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox