From: k.kozlowski@samsung•com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3] arm: irq: l2c: do not print error in case of missing l2c from dtb
Date: Wed, 13 Jan 2016 08:55:33 +0900 [thread overview]
Message-ID: <56959275.80404@samsung.com> (raw)
In-Reply-To: <1452593472-10703-1-git-send-email-andi.shyti@samsung.com>
On 12.01.2016 19:11, Andi Shyti wrote:
> In some architectures the L2 cache controller is integrated in the
> processor's block itself and it doesn't use any external cache
> controller. This means that an entry in the board's dtb related
> to the l2c is not necessary.
>
> Distinguish between error codes and do not print anything in case
> l2x0_of_init() doesn't find any L2C DTB entry and returns -ENODEV.
>
> This patch mutes the following error message:
>
> L2C: failed to init: -19
>
> on boards like odroid-xu4, cortex A7/A15, which don't have
> external cache controller.
>
> Signed-off-by: Andi Shyti <andi.shyti@samsung•com>
> Reported-by: Krzysztof Kozlowski <k.kozlowski@samsung•com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung•com>
> ---
> Hi,
>
> here is a second version. An alternative would be to print with
> pr_dbg, but then it's a matter of taste.
>
> V1, and V2 print a message in case the l2c dtb entry is not found
> (the V2 has a better print rephrase suggested by Joe)
>
> V3 ignores the case of -enodev for l2c and doesn't print anything
>
> Thanks,
> Andi
Looks good to me, as v2 did. Works fine:
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung•com>
BR,
KRzysztof
next prev parent reply other threads:[~2016-01-12 23:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 6:34 [PATCH] arm: irq: l2c: do not print error in case of missing l2c from dtb Andi Shyti
2016-01-12 7:11 ` Joe Perches
2016-01-12 7:24 ` [PATCH v2] " Andi Shyti
2016-01-12 8:28 ` Krzysztof Kozlowski
2016-01-12 8:35 ` [PATCH] " Marek Szyprowski
2016-01-12 10:11 ` [PATCH v3] " Andi Shyti
2016-01-12 23:55 ` Krzysztof Kozlowski [this message]
2016-01-20 18:02 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56959275.80404@samsung.com \
--to=k.kozlowski@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox