From: k.kozlowski@samsung•com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 2/2] power: add documentation for ACT8945A's charger DT bindings
Date: Wed, 13 Jan 2016 11:00:13 +0900 [thread overview]
Message-ID: <5695AFAD.4030307@samsung.com> (raw)
In-Reply-To: <1452586185-818-3-git-send-email-wenyou.yang@atmel.com>
On 12.01.2016 17:09, Wenyou Yang wrote:
> This patch adds documentation for the DT bindings of the charger
> subdevice of ACT8945A MFD.
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel•com>
> ---
>
> Changes in v3: None
> Changes in v2: None
>
> .../devicetree/bindings/power/act8945a-charger.txt | 34 ++++++++++++++++++++
> 1 file changed, 34 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/act8945a-charger.txt
>
> diff --git a/Documentation/devicetree/bindings/power/act8945a-charger.txt b/Documentation/devicetree/bindings/power/act8945a-charger.txt
> new file mode 100644
> index 0000000..868e0164
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/act8945a-charger.txt
> @@ -0,0 +1,34 @@
> +Device-Tree bindings for charger of Active-semi ACT8945A Multi-Function Device
> +
> +Required properties:
> + - compatible: "active-semi,act8945a-charger"
> + - active-semi,chglev-gpio = Specifies a gpio that uses to select
> + the charge current level.
active-semi,chglev-gpios
See: Documentation/devicetree/bindings/gpio/gpio.txt
> +
> +Optional properties:
> + - active-semi,battery_temperature: Indicates if it is allowed to check
> + the battery temperature. If it is missing, assume the battery temperature
> + is not allowed to check.
Here and in rest of properties - no underscores but hyphens. The name
suggests that this is a value... but this is a boolean?
> + - active-semi,input_voltage_threshold: unit: mV;
> + Specifies the charger's input over-voltage threshold value;
> + The value can be: 6600, 7000, 7500, 8000; default: 6600
I think adding units suffix in binding is preferred. so "-microvolt"?
Best regards,
Krzysztof
> + - active-semi,precondition_timeout: unit: minutes;
> + Specifies the charger's PRECONDITION safety timer setting value;
> + The value can be: 40, 60, 80, 0; If 0, it means to disable this timer;
> + default: 40.
> + - active-semi,total_timeout: unit: hours;
> + Specifies the charger's total safety timer setting value;
> + The value can be: 3, 4, 5, 0; If 0, it means to disable this timer;
> + default: 3.
> +
> +Example:
> +
> + charger {
> + compatible = "active-semi,act8945a-charger";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_charger_chglev>;
> + active-semi,chglev-gpio = <&pioA 12 GPIO_ACTIVE_HIGH>;
> + active-semi,input_voltage_threshold = <6600>;
> + active-semi,precondition_timeout = <40>;
> + active-semi,total_timeout = <3>;
> + };
>
next prev parent reply other threads:[~2016-01-13 2:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 8:09 [PATCH v3 0/2] power: act8945a: add charger driver for the sub-device of ACT8945A MFD Wenyou Yang
2016-01-12 8:09 ` [PATCH v3 1/2] power: act8945a: add charger driver for ACT8945A Wenyou Yang
2016-01-13 2:11 ` Krzysztof Kozlowski
2016-01-13 3:53 ` Yang, Wenyou
2016-01-13 4:09 ` Krzysztof Kozlowski
2016-01-13 4:31 ` Yang, Wenyou
2016-01-12 8:09 ` [PATCH v3 2/2] power: add documentation for ACT8945A's charger DT bindings Wenyou Yang
2016-01-13 2:00 ` Krzysztof Kozlowski [this message]
2016-01-13 3:50 ` Yang, Wenyou
2016-01-13 1:48 ` [PATCH v3 0/2] power: act8945a: add charger driver for the sub-device of ACT8945A MFD Krzysztof Kozlowski
2016-01-13 2:13 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5695AFAD.4030307@samsung.com \
--to=k.kozlowski@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox