From: bart.vanassche@sandisk•com (Bart Van Assche)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] scsi: qla2xxxx: avoid type mismatch in comparison
Date: Wed, 20 Jan 2016 08:10:32 -0800 [thread overview]
Message-ID: <569FB178.9050101@sandisk.com> (raw)
In-Reply-To: <1603472.f34vvTrhuN@wuerfel>
On 01/20/2016 02:47 AM, Arnd Bergmann wrote:
> A recent bug fix added code that does
>
> bool logged_out = (status & 0xFFFF);
> if (logged_out == CTIO_PORT_LOGGED_OUT)
> ...
>
> This looks wrong because we are comparing a boolean with an
> integer constant, ang gcc warns about it accordingly:
>
> drivers/scsi/qla2xxx/qla_target.c: In function 'qlt_do_ctio_completion':
> drivers/scsi/qla2xxx/qla_target.c:3587:20: warning: comparison of constant '41' with boolean expression is always false [-Wbool-compare]
> (logged_out == CTIO_PORT_LOGGED_OUT) ?
>
> The correct fix is presumably to make that variable an 'int'.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
> Fixes: 71cdc0796465 ("qla2xxx: Delete session if initiator is gone from FW")
> ---
> The patch introducing this is currenly in linux-next through the target-updates/for-next
> branch.
>
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index c7ab9e69c881..8075a4cdb45c 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -3580,7 +3580,7 @@ static void qlt_do_ctio_completion(struct scsi_qla_host *vha, uint32_t handle,
> case CTIO_PORT_LOGGED_OUT:
> case CTIO_PORT_UNAVAILABLE:
> {
> - bool logged_out = (status & 0xFFFF);
> + int logged_out = (status & 0xFFFF);
> ql_dbg(ql_dbg_tgt_mgt, vha, 0xf059,
> "qla_target(%d): CTIO with %s status %x "
> "received (state %x, se_cmd %p)\n", vha->vp_idx,
>
Hello Arnd,
Please read the e-mail thread that is available at
http://thread.gmane.org/gmane.linux.scsi/108899/focus=108943. That
thread namely makes it clear that the above patch is not the proper way
to fix that code.
Thanks,
Bart.
prev parent reply other threads:[~2016-01-20 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 10:47 [PATCH] scsi: qla2xxxx: avoid type mismatch in comparison Arnd Bergmann
2016-01-20 11:04 ` Nicholas A. Bellinger
2016-01-20 16:10 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569FB178.9050101@sandisk.com \
--to=bart.vanassche@sandisk$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox