From: nicolas.ferre@atmel•com (Nicolas Ferre)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: dts: at91: sama5d4_xplained: properly mux phy interrupt
Date: Fri, 22 Jan 2016 17:12:06 +0100 [thread overview]
Message-ID: <56A254D6.3070105@atmel.com> (raw)
In-Reply-To: <1452846618-17854-1-git-send-email-alexandre.belloni@free-electrons.com>
Le 15/01/2016 09:30, Alexandre Belloni a ?crit :
> No interrupt were received from the phy because PIOE 1 may not be properly
> muxed. It prevented proper link detection, especially since commit
> 321beec5047a ("net: phy: Use interrupts when available in NOLINK state")
> disables polling.
>
> Cc: <stable@vger•kernel.org> # 4.4
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons•com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel•com>
And added to the upcoming at91-4.5-fixes branch.
thanks!
> ---
> arch/arm/boot/dts/at91-sama5d4_xplained.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> index 131614f28e75..8cf9999cb0cd 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> @@ -86,6 +86,8 @@
> macb0: ethernet at f8020000 {
> phy-mode = "rmii";
> status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_macb0_rmii &pinctrl_macb0_phy_irq>;
>
> phy0: ethernet-phy at 1 {
> interrupt-parent = <&pioE>;
> @@ -152,6 +154,10 @@
> atmel,pins =
> <AT91_PIOE 8 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
> };
> + pinctrl_macb0_phy_irq: macb0_phy_irq_0 {
> + atmel,pins =
> + <AT91_PIOE 1 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
> + };
> };
> };
> };
>
--
Nicolas Ferre
prev parent reply other threads:[~2016-01-22 16:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 8:30 [PATCH] ARM: dts: at91: sama5d4_xplained: properly mux phy interrupt Alexandre Belloni
2016-01-22 16:12 ` Nicolas Ferre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A254D6.3070105@atmel.com \
--to=nicolas.ferre@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox