From: blogic@openwrt•org (John Crispin)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2 4/4] mfd: mediatek: add MT6323 support to MT6397 driver
Date: Mon, 25 Jan 2016 16:36:40 +0100 [thread overview]
Message-ID: <56A64108.7020807@openwrt.org> (raw)
In-Reply-To: <20160125124112.GG3368@x1>
Hi,
On 25/01/2016 13:41, Lee Jones wrote:
> Please honour the subject format of the subsystem you are contributing
> to.
>
> `git log --oneline -- $subsystem` gives you this.
>
> On Mon, 25 Jan 2016, John Crispin wrote:
>
>> Signed-off-by: John Crispin <blogic@openwrt•org>
>> ---
[...]
>> @@ -261,6 +271,15 @@ static int mt6397_probe(struct platform_device *pdev)
>> }
>>
>> switch (id & 0xff) {
>> + case MT6323_CID_CODE:
>> + mt6397->int_con[0] = MT6323_INT_CON0;
>
> This is confusing. You're still using memory allocated for a mt6397
> device.
>
the variable is currently defined as struct mt6397_chip *mt6397;
shall i only change the name or also create a patch to rename the struct ?
John
next prev parent reply other threads:[~2016-01-25 15:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 10:14 [PATCH V2 0/4] mfd: mediatek: add mt6323 support to the mt6397 driver John Crispin
2016-01-25 10:14 ` [PATCH V2 1/4] dt-bindings: mfd: Add bindings for the MediaTek MT6323 PMIC John Crispin
2016-01-25 12:41 ` Lee Jones
2016-01-25 10:14 ` [PATCH V2 2/4] mfd: mediatek: int_con and int_status may vary in location John Crispin
2016-01-25 12:33 ` Lee Jones
2016-01-25 10:14 ` [PATCH V2 3/4] mfd: mediatek: add support for different Slave types John Crispin
2016-01-25 12:37 ` Lee Jones
2016-01-25 10:14 ` [PATCH V2 4/4] mfd: mediatek: add MT6323 support to MT6397 driver John Crispin
2016-01-25 12:41 ` Lee Jones
2016-01-25 15:36 ` John Crispin [this message]
2016-01-25 18:44 ` Matthias Brugger
2016-01-25 18:59 ` John Crispin
2016-01-26 3:07 ` Henry Chen
2016-01-26 7:14 ` John Crispin
2016-01-26 8:34 ` Lee Jones
2016-01-26 8:44 ` John Crispin
2016-01-26 12:05 ` John Crispin
2016-01-26 14:00 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A64108.7020807@openwrt.org \
--to=blogic@openwrt$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox