From: rjui@broadcom•com (Ray Jui)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: bcm: use const and __initconst for smp_operations
Date: Mon, 25 Jan 2016 09:15:45 -0800 [thread overview]
Message-ID: <56A65841.1040100@broadcom.com> (raw)
In-Reply-To: <1453721475-15156-1-git-send-email-yamada.masahiro@socionext.com>
Hi Masahiro,
On 1/25/2016 3:31 AM, Masahiro Yamada wrote:
> This newly added code missed the global fixup by commit 75305275a721
> ("ARM: use const and __initconst for smp_operations"). So fix it now.
>
> Also, add missing "static" qualifier.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext•com>
> ---
>
> arch/arm/mach-bcm/platsmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-bcm/platsmp.c b/arch/arm/mach-bcm/platsmp.c
> index 575defc..cfae9c7 100644
> --- a/arch/arm/mach-bcm/platsmp.c
> +++ b/arch/arm/mach-bcm/platsmp.c
> @@ -283,7 +283,7 @@ static const struct smp_operations bcm_smp_ops __initconst = {
> CPU_METHOD_OF_DECLARE(bcm_smp_bcm281xx, "brcm,bcm11351-cpu-method",
> &bcm_smp_ops);
>
> -struct smp_operations nsp_smp_ops __initdata = {
> +static const struct smp_operations nsp_smp_ops __initconst = {
> .smp_prepare_cpus = bcm_smp_prepare_cpus,
> .smp_boot_secondary = nsp_boot_secondary,
> };
>
This fix looks good to me. Thanks!
Reviewed-by: Ray Jui <rjui@broadcom•com>
next prev parent reply other threads:[~2016-01-25 17:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 11:31 [PATCH] ARM: bcm: use const and __initconst for smp_operations Masahiro Yamada
2016-01-25 17:15 ` Ray Jui [this message]
2016-02-01 21:11 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A65841.1040100@broadcom.com \
--to=rjui@broadcom$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox