From: cw00.choi@samsung•com (Chanwoo Choi)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 2/3] clk: samsung: Don't build ARMv8 clock drivers on ARMv7
Date: Thu, 28 Jan 2016 10:23:07 +0900 [thread overview]
Message-ID: <56A96D7B.7080505@samsung.com> (raw)
In-Reply-To: <1453941324-15742-3-git-send-email-k.kozlowski@samsung.com>
On 2016? 01? 28? 09:35, Krzysztof Kozlowski wrote:
> Currently the Exynos5433 (ARMv8 SoC) clock driver depends on ARCH_EXYNOS
> so it is built also on ARMv7. This does not bring any kind of benefit.
> There won't be a single kernel image for ARMv7 and ARMv8 SoCs (like
> multi_v7 for ARMv7).
>
> Instead build clock drivers only for respective SoC's architecture.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung•com>
>
> ---
>
> Changes since v3:
> 1. Rebase on next-20160127.
>
> Changes since v2:
> 1. Follow Arnd's advice making EXYNOS_ARM64_COMMON_CLK user-visible when
> COMPILE_TEST is enabled.
> 2. Dropped accumulated tags because the logic is now different.
>
> Changes since v1:
> 1. Use one Kconfig symbol for clocks of all ARM64 SoCs (after
> discussion): EXYNOS_ARM64_COMMON_CLK.
> 2. Minor cleanups after Tomasz's comments.
> 3. Added tags: Chanwoo's, Sylwester's, Alim's and Tomasz's (the tags
> were given for v1 but assuming that change from 1. is not major
> enough to require re-tagging).
> ---
> drivers/clk/samsung/Kconfig | 5 +++++
> drivers/clk/samsung/Makefile | 4 ++--
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig
> index dd6093a33f84..5fd982d9f4d9 100644
> --- a/drivers/clk/samsung/Kconfig
> +++ b/drivers/clk/samsung/Kconfig
> @@ -23,3 +23,8 @@ config S3C2443_COMMON_CLK
> bool "Samsung S3C2443 clock controller support" if COMPILE_TEST
> select COMMON_CLK_SAMSUNG
>
> +# ARM64 SoCs (e.g. Exynos5433, Exynos7):
> +config EXYNOS_ARM64_COMMON_CLK
> + bool "Samsung Exynos ARMv8-family clock controller support" if COMPILE_TEST
> + default ARM64 && COMMON_CLK_SAMSUNG
> + depends on (ARM64 && COMMON_CLK_SAMSUNG) || COMPILE_TEST
> diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile
> index 5f6833ea355d..fc367d4b2902 100644
> --- a/drivers/clk/samsung/Makefile
> +++ b/drivers/clk/samsung/Makefile
> @@ -10,11 +10,11 @@ obj-$(CONFIG_SOC_EXYNOS5250) += clk-exynos5250.o
> obj-$(CONFIG_SOC_EXYNOS5260) += clk-exynos5260.o
> obj-$(CONFIG_SOC_EXYNOS5410) += clk-exynos5410.o
> obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5420.o
> -obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos5433.o
> +obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos5433.o
> obj-$(CONFIG_SOC_EXYNOS5440) += clk-exynos5440.o
> obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-audss.o
> obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-clkout.o
> -obj-$(CONFIG_ARCH_EXYNOS7) += clk-exynos7.o
> +obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos7.o
> obj-$(CONFIG_S3C2410_COMMON_CLK)+= clk-s3c2410.o
> obj-$(CONFIG_S3C2410_COMMON_DCLK)+= clk-s3c2410-dclk.o
> obj-$(CONFIG_S3C2412_COMMON_CLK)+= clk-s3c2412.o
>
Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung•com>
Best Regards,
Chanwoo Choi
next prev parent reply other threads:[~2016-01-28 1:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 0:35 [PATCH v4 0/3] arm64/clk: EXYNOS: Consolidate Exynos7 symbol Krzysztof Kozlowski
2016-01-28 0:35 ` [PATCH v4 1/3] clk: samsung: Enable COMPILE_TEST for Samsung clocks Krzysztof Kozlowski
2016-01-28 19:12 ` Javier Martinez Canillas
2016-01-29 20:43 ` Stephen Boyd
2016-01-28 0:35 ` [PATCH v4 2/3] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 Krzysztof Kozlowski
2016-01-28 1:23 ` Chanwoo Choi [this message]
2016-01-28 19:15 ` Javier Martinez Canillas
2016-01-29 20:43 ` Stephen Boyd
2016-01-28 0:35 ` [PATCH v4 3/3] arm64: EXYNOS: Consolidate ARCH_EXYNOS7 symbol into ARCH_EXYNOS Krzysztof Kozlowski
2016-01-28 19:16 ` Javier Martinez Canillas
2016-01-29 1:13 ` [PATCH v4 0/3] arm64/clk: EXYNOS: Consolidate Exynos7 symbol Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A96D7B.7080505@samsung.com \
--to=cw00.choi@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox