From: t-kristo@ti•com (Tero Kristo)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] clk: ti: omap3+: dpll: use non-locking version of clk_get_rate
Date: Thu, 28 Jan 2016 21:09:41 +0200 [thread overview]
Message-ID: <56AA6775.5090302@ti.com> (raw)
In-Reply-To: <20160128190026.GI19432@atomide.com>
On 01/28/2016 09:00 PM, Tony Lindgren wrote:
> * Tero Kristo <t-kristo@ti•com> [160128 10:48]:
>> On 01/28/2016 07:22 PM, Tony Lindgren wrote:
>>> * Tero Kristo <t-kristo@ti•com> [160128 03:44]:
>>>> On 01/28/2016 01:37 PM, Tero Kristo wrote:
>>>>> As the code in this file is being executed within irq context in some
>>>>> cases, we must avoid the clk_get_rate which uses mutex internally.
>>>>> Switch the code to use clk_hw_get_rate instead which is non-locking.
>>>>>
>>>>> Signed-off-by: Tero Kristo <t-kristo@ti•com>
>>>>
>>>> Ooops, sorry. Sent wrong version (read: old) of this patch, please ignore
>>>> this one. Will re-send the correct version in a bit.
>>>
>>> I think this is still needed as a fix for -rc cycle with cc: stable
>>> as otherwise we have omap4 and 5 hang if PM runtime is enabled before
>>> a suspend/resume cycle?
>>
>> Look at the other patch I sent, it should accomplish the same thing, and
>> more.
>>
>> https://www.spinics.net/lists/linux-clk/msg06094.html
>
> Right.. But is that suitable for the -rc cycle with cc stable?
Hmm yea, thats a good question, we may need to resurrect this patch
after all.
> You should also describe the bug it causes in the change log.
> Something like:
>
> This fixes an issue where PM runtime will hang the system if
> enabled with a serial console before a suspend-resume cycle.
Yea I can add this to the desc if we want to keep this version of the patch.
-Tero
next prev parent reply other threads:[~2016-01-28 19:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 11:37 [PATCH] clk: ti: omap3+: dpll: use non-locking version of clk_get_rate Tero Kristo
2016-01-28 11:43 ` Tero Kristo
2016-01-28 17:22 ` Tony Lindgren
2016-01-28 18:48 ` Tero Kristo
2016-01-28 19:00 ` Tony Lindgren
2016-01-28 19:09 ` Tero Kristo [this message]
2016-01-28 19:19 ` Tony Lindgren
2016-02-15 21:31 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AA6775.5090302@ti.com \
--to=t-kristo@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox