From: k.kozlowski@samsung•com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/6] ARM: s3c24xx: don't select RFKILL if CONFIG_NET is disabled
Date: Mon, 01 Feb 2016 09:59:48 +0900 [thread overview]
Message-ID: <56AEAE04.6030601@samsung.com> (raw)
In-Reply-To: <1454079040-3567945-5-git-send-email-arnd@arndb.de>
On 29.01.2016 23:50, Arnd Bergmann wrote:
> Bluetooth is only supported when network support is part of the kernel,
> so it is a bit pointless to build the hi1940-bt support without networking.
> If we try anyway, we get a Kconfig warning:
>
> warning: (TOSA_BT && H1940BT) selects RFKILL which has unmet direct dependencies (NET)
>
> This adds a dependency on CONFIG_NET to avoid that case.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
> ---
> arch/arm/mach-s3c24xx/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig
> index 5884bbb7952e..bf66c8334822 100644
> --- a/arch/arm/mach-s3c24xx/Kconfig
> +++ b/arch/arm/mach-s3c24xx/Kconfig
> @@ -227,7 +227,7 @@ config ARCH_H1940
>
> config H1940BT
> tristate "Control the state of H1940 bluetooth chip"
> - depends on ARCH_H1940
> + depends on ARCH_H1940 && NET
> select RFKILL
> help
> This is a simple driver that is able to control
I think there shouldn't be a reverse dependency for RFKILL but instead just:
depends on ARCH_H1940 && RFKILL
This makes it simpler and RFKILL is a user-visible symbol.
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-02-01 0:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 14:50 [PATCH 0/6] ARM: samsung warning fixes Arnd Bergmann
2016-01-29 14:50 ` [PATCH 1/6] ARM: s3c24xx: don't select EEPROM_AT24 Arnd Bergmann
2016-02-01 0:40 ` Krzysztof Kozlowski
2016-01-29 14:50 ` [PATCH 2/6] ARM: s3c24xx: allow selecting S3C2440_XTAL_16934400 for s3c2442 Arnd Bergmann
2016-02-01 0:46 ` Krzysztof Kozlowski
2016-01-29 14:50 ` [PATCH 3/6] ARM: s3c24xx: fix unused gta02_configure_pmu_for_charger warning Arnd Bergmann
2016-02-01 0:49 ` Krzysztof Kozlowski
2016-01-29 14:50 ` [PATCH 4/6] ARM: s3c24xx: don't select RFKILL if CONFIG_NET is disabled Arnd Bergmann
2016-02-01 0:59 ` Krzysztof Kozlowski [this message]
2016-01-29 14:50 ` [PATCH 5/6] ARM: s3c64xx: mark regulator init data as unused Arnd Bergmann
2016-02-01 1:18 ` Krzysztof Kozlowski
2016-01-29 14:50 ` [PATCH 6/6] ARM: exynos: select THERMAL_OF Arnd Bergmann
2016-02-01 1:26 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AEAE04.6030601@samsung.com \
--to=k.kozlowski@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox