From: grygorii.strashko@ti•com (Grygorii Strashko)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] ARM: make virt_to_idmap() return unsigned long
Date: Wed, 3 Feb 2016 16:14:06 +0200 [thread overview]
Message-ID: <56B20B2E.7060408@ti.com> (raw)
In-Reply-To: <56B14546.4070808@oracle.com>
On 02/03/2016 02:09 AM, santosh shilimkar wrote:
> Vitaly,
>
> On 2/1/2016 9:10 AM, santosh shilimkar wrote:
>> On 2/1/2016 9:01 AM, Vitaly Andrianov wrote:
>>>
>>>
>>> On 02/01/2016 10:20 AM, Russell King - ARM Linux wrote:
>>>> On Tue, Jan 26, 2016 at 08:27:52PM -0800, santosh.shilimkar at oracle.com
>>>> wrote:
>>>>> On 1/26/16 10:21 AM, Russell King wrote:
>>>>>> Make virt_to_idmap() return an unsigned long rather than phys_addr_t.
>>>>>>
>>>>>> Returning phys_addr_t here makes no sense, because the definition of
>>>>>> virt_to_idmap() is that it shall return a physical address which maps
>>>>>> identically with the virtual address. Since virtual addresses are
>>>>>> limited to 32-bit, identity mapped physical addresses are as well.
>>>>>>
>>>>>> Almost all users already had an implicit narrowing cast to unsigned
>>>>>> long
>>>>>> so let's make this official and part of this interface.
>>>>>>
>>>>>> Signed-off-by: Russell King <rmk+kernel@arm•linux.org.uk>
>>>>>> ---
>>>>> Looks correct to me.
>>>>>
>>>>> Vitaly,
>>>>> Could you please try out this patch and see everything continue to
>>>>> work ?
>>>>
>>>> I haven't heard anything yet... Vitaly?
>>>>
>>> Russel, Santosh,
>>>
>>> I'm not working with the latest kernel, but with the stable v4.1.y. So I
>>> couldn't apply the patch to it. I checked out 4.5.0-rc1 and applied the
>>> patch to it. Tried to boot and it crashed. I'm not sure either because
>>> of the patch or because of the network driver.
>>>
>> Thanks for checking.
>>
>>> Here is the log:
>>>
>> Based on the log, I think the patch seems to work fine since the boot
>> reached upto rootfs. The crash seems to be coming from mostky NetCP
>> related compents.
>>
> The NETCP crash you saw could be the same one others stumbled as
> mentioned in below thread. You can try the fix and see if the
> crash goes away.
>
> http://marc.info/?l=linux-netdev&m=145445399232540&w=2
100%. I came up with absolutely similar fix.
Regarding, kexec:
- it seems can't be tested on ks2 out of the box, because there is unmet dependency in kconfig
config KEXEC
bool "Kexec system call (EXPERIMENTAL)"
- depends on (!SMP || PM_SLEEP_SMP)
depends on !CPU_V7M
select KEXEC_CORE
help
- any way, i've hacked kernel as above;
- downloaded and built kexec-tools
git://git.kernel.org/pub/scm/linux/kernel/git/geoff/kexec-tools.git
- tried to run it using different combination of parameters, but always
with below result:
# kexec -l /boot/zImage
kexec version: 15.12.22.16.38-g6503cb3
Could not find a free area of memory of 0x3b2ca0 bytes...
Cannot load /boot/zImage
I'm doing something wrong, but don't know what yet :(
- these patches were not applied, I'd like to see kexec not working first
--
regards,
-grygorii
next prev parent reply other threads:[~2016-02-03 14:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 18:21 [PATCH 1/2] ARM: make virt_to_idmap() return unsigned long Russell King
2016-01-27 4:27 ` santosh.shilimkar at oracle.com
2016-02-01 15:20 ` Russell King - ARM Linux
2016-02-01 17:01 ` Vitaly Andrianov
2016-02-01 17:10 ` santosh shilimkar
2016-02-01 17:31 ` Russell King - ARM Linux
2016-02-01 17:55 ` santosh.shilimkar at oracle.com
2016-02-03 0:09 ` santosh shilimkar
2016-02-03 14:14 ` Grygorii Strashko [this message]
2016-02-03 15:43 ` Vitaly Andrianov
2016-02-03 19:59 ` Russell King - ARM Linux
2016-02-04 11:53 ` Grygorii Strashko
2016-02-08 17:10 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B20B2E.7060408@ti.com \
--to=grygorii.strashko@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox