From: marc.zyngier@arm•com (Marc Zyngier)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/4] arm64: Rename cpuid_feature field extract routines
Date: Wed, 3 Feb 2016 14:16:18 +0000 [thread overview]
Message-ID: <56B20BB2.4020700@arm.com> (raw)
In-Reply-To: <20160203140632.GB16727@e104818-lin.cambridge.arm.com>
On 03/02/16 14:06, Catalin Marinas wrote:
> On Tue, Jan 26, 2016 at 10:58:16AM +0000, Suzuki K. Poulose wrote:
>> Now that we have a clear understanding of the sign of a feature,
>> rename the routines to reflect the sign, so that it is not misused.
>> The cpuid_feature_extract_field() now accepts a 'sign' parameter.
>>
>> Signed-off-by: Suzuki K. Poulose <suzuki.poulose@arm•com>
> [...]
>> diff --git a/arch/arm64/include/asm/kvm_mmu.h b/arch/arm64/include/asm/kvm_mmu.h
>> index 7364339..2ac4a22 100644
>> --- a/arch/arm64/include/asm/kvm_mmu.h
>> +++ b/arch/arm64/include/asm/kvm_mmu.h
>> @@ -307,7 +307,7 @@ static inline unsigned int kvm_get_vmid_bits(void)
>> {
>> int reg = read_system_reg(SYS_ID_AA64MMFR1_EL1);
>>
>> - return (cpuid_feature_extract_field(reg, ID_AA64MMFR1_VMIDBITS_SHIFT) == 2) ? 16 : 8;
>> + return (cpuid_feature_extract_unsigned_field(reg, ID_AA64MMFR1_VMIDBITS_SHIFT) == 2) ? 16 : 8;
>> }
>
> Since this is touch a KVM file, it would be good to have an ack from
> Marc or Christoffer.
Works for me.
Acked-by: Marc Zyngier <marc.zyngier@arm•com>
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2016-02-03 14:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 10:58 [PATCH 0/4] arm64: cpufeature: Fix sign of feature bits Suzuki K Poulose
2016-01-26 10:58 ` [PATCH 1/4] arm64: cpufeature: Correct feature register tables Suzuki K Poulose
2016-01-26 10:58 ` [PATCH 2/4] arm64: cpufeature: Fix the sign of feature bits Suzuki K Poulose
2016-01-26 10:58 ` [PATCH 3/4] arm64: capabilities: Handle sign of the feature bit Suzuki K Poulose
2016-01-26 10:58 ` [PATCH 4/4] arm64: Rename cpuid_feature field extract routines Suzuki K Poulose
2016-02-03 14:06 ` Catalin Marinas
2016-02-03 14:16 ` Marc Zyngier [this message]
2016-01-26 11:24 ` [PATCH 0/4] arm64: cpufeature: Fix sign of feature bits Suzuki K. Poulose
2016-02-09 17:24 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B20BB2.4020700@arm.com \
--to=marc.zyngier@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox