From: timur@codeaurora•org (Timur Tabi)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support
Date: Wed, 3 Feb 2016 11:53:29 -0600 [thread overview]
Message-ID: <56B23E99.1030604@codeaurora.org> (raw)
In-Reply-To: <CADyBb7sxPg-QUjTbeHFtYkctKc_g7D8O=+jqbXN+DCCoCEnFqA@mail.gmail.com>
Fu Wei wrote:
> sorry, are you saying : using pre-timeout instead of this half timeout?
>
> But even we have pre-timeout support, pre-timeout == timeout / 2, it
> can not be configured without touch timeout.
>
> if you want pre-timeout != timeout / 2, we have to modify WCV in the
> interrupt routine.
> (because of the explicit watchdog refresh mechanism)
>
> Could you let me know why we need pre-timeout here ??:-)
What I meant was that if we had full-blown pre-timeout support in the
watchdog layer, then you could use that to implement the
panic-on-half-timeout feature.
When pre-timeout is implemented, will you modify the interrupt handler
to use it?
>> >belong upstream. But like I said, it's just my opinion, and I won't
>> >complain if I'm outvoted.
> I think this debugging feature is the purpose of the two-stage
> watchdog, if I understand correctly
Hmmm... that make sense. I think maybe you should drop the Kconfig
option, and just have "static bool panic_enabled = false;" Also, then
do this:
if (panic_enabled) {
ret = devm_request_irq(dev, irq, sbsa_gwdt_interrupt, 0,
pdev->name, gwdt);
if (ret) {
dev_err(dev, "unable to request IRQ %d\n", irq);
return ret;
}
}
That way, the interrupt handler is never registered if the command-line
parameter is not specified.
next prev parent reply other threads:[~2016-02-03 17:53 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 17:18 [PATCH v10 0/5] Watchdog: introduce ARM SBSA watchdog driver fu.wei at linaro.org
2016-02-03 17:18 ` [PATCH v10 1/5] Documentation: add sbsa-gwdt driver documentation fu.wei at linaro.org
2016-02-03 17:18 ` [PATCH v10 2/5] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts fu.wei at linaro.org
2016-02-03 17:18 ` [PATCH v10 3/5] ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi fu.wei at linaro.org
2016-02-03 17:18 ` [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver fu.wei at linaro.org
2016-02-03 17:48 ` Timur Tabi
2016-02-03 17:57 ` Fu Wei
2016-02-03 17:58 ` Timur Tabi
2016-02-03 18:09 ` Fu Wei
2016-02-03 18:12 ` Timur Tabi
2016-02-04 16:25 ` Mathieu Poirier
2016-02-05 9:01 ` Fu Wei
2016-02-04 16:31 ` Will Deacon
2016-02-04 16:37 ` Timur Tabi
2016-02-04 16:46 ` Guenter Roeck
2016-02-05 8:52 ` Fu Wei
2016-02-03 17:18 ` [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support fu.wei at linaro.org
2016-02-03 17:27 ` Timur Tabi
2016-02-03 17:49 ` Fu Wei
2016-02-03 17:53 ` Timur Tabi [this message]
2016-02-03 18:06 ` Fu Wei
2016-02-03 18:08 ` Timur Tabi
2016-02-03 18:18 ` Fu Wei
2016-02-03 18:26 ` Timur Tabi
2016-02-03 18:37 ` Fu Wei
2016-02-03 18:45 ` Timur Tabi
2016-02-03 23:00 ` Fu Wei
2016-02-04 5:17 ` Guenter Roeck
2016-02-04 13:48 ` Timur Tabi
2016-02-04 14:41 ` Guenter Roeck
2016-02-05 9:51 ` Fu Wei
2016-02-05 13:02 ` Thomas Petazzoni
2016-02-05 13:08 ` Timur Tabi
2016-02-05 13:33 ` Thomas Petazzoni
2016-02-05 14:42 ` Guenter Roeck
2016-02-05 18:21 ` Fu Wei
2016-02-05 23:54 ` Guenter Roeck
2016-02-06 18:02 ` Fu Wei
2016-02-06 18:55 ` Timur Tabi
2016-02-07 2:02 ` Fu Wei
2016-02-06 18:57 ` Guenter Roeck
2016-02-07 2:12 ` Fu Wei
2016-02-04 16:32 ` Mathieu Poirier
2016-02-04 16:41 ` Guenter Roeck
2016-02-04 16:43 ` Timur Tabi
2016-02-05 9:20 ` Fu Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B23E99.1030604@codeaurora.org \
--to=timur@codeaurora$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox