From: hdegoede@redhat•com (Hans de Goede)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 3/3] reset: Add support for shared reset controls
Date: Fri, 5 Feb 2016 19:28:45 +0100 [thread overview]
Message-ID: <56B4E9DD.3060000@redhat.com> (raw)
In-Reply-To: <1454663304.6406.3.camel@pengutronix.de>
Hi,
On 05-02-16 10:08, Philipp Zabel wrote:
> Am Mittwoch, den 27.01.2016, 19:15 +0100 schrieb Hans de Goede:
> [...]
>> @@ -94,9 +99,16 @@ EXPORT_SYMBOL_GPL(reset_controller_unregister);
>> /**
>> * reset_control_reset - reset the controlled device
>> * @rstc: reset controller
>> + *
>> + * Calling this on a shared reset controller is an error.
>> */
>> int reset_control_reset(struct reset_control *rstc)
>> {
>> + if (rstc->shared) {
>> + WARN_ON(1);
>> + return -EINVAL;
>
> Occurrences of
> if (condition) {
> WARN_ON(1);
> ...
> }
> could be changed to
> if (WARN_ON(condition)) {
> ...
> }
Good one, will fix for v4 (v2 of the second attempt at this).
Regards,
Hans
prev parent reply other threads:[~2016-02-05 18:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 18:15 [PATCH v3 0/3] reset: Add support for shared reset controls Hans de Goede
2016-01-27 18:15 ` [PATCH v3 1/3] reset: Make [of_]reset_control_get[_foo] functions wrappers Hans de Goede
2016-02-04 16:54 ` Philipp Zabel
2016-02-05 18:30 ` Hans de Goede
2016-02-08 9:58 ` Philipp Zabel
2016-01-27 18:15 ` [PATCH v3 2/3] reset: Share struct reset_control between reset_control_get calls Hans de Goede
2016-01-27 18:15 ` [PATCH v3 3/3] reset: Add support for shared reset controls Hans de Goede
2016-01-28 20:20 ` Stephen Warren
2016-01-29 6:18 ` Hans de Goede
2016-01-29 16:21 ` Stephen Warren
2016-01-30 11:38 ` Philipp Zabel
2016-01-31 9:12 ` Hans de Goede
2016-02-04 16:55 ` Philipp Zabel
2016-02-05 9:08 ` Philipp Zabel
2016-02-05 18:28 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B4E9DD.3060000@redhat.com \
--to=hdegoede@redhat$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox