From: marc.zyngier@arm•com (Marc Zyngier)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 6/6] kvm: arm64: Add ACPI support for virt arch timer
Date: Mon, 8 Feb 2016 17:10:00 +0000 [thread overview]
Message-ID: <56B8CBE8.7020305@arm.com> (raw)
In-Reply-To: <1454358418-5157-7-git-send-email-fu.wei@linaro.org>
On 01/02/16 20:26, fu.wei at linaro.org wrote:
> From: Fu Wei <fu.wei@linaro•org>
>
> This patch adds ACPI/GTDT support for virt arch timer
> using the API in GTDT driver.
>
> Signed-off-by: Fu Wei <fu.wei@linaro•org>
> ---
> virt/kvm/arm/arch_timer.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/virt/kvm/arm/arch_timer.c b/virt/kvm/arm/arch_timer.c
> index 0a279d3..4077347 100644
> --- a/virt/kvm/arm/arch_timer.c
> +++ b/virt/kvm/arm/arch_timer.c
> @@ -385,6 +385,9 @@ static int kvm_timer_get_ppi(unsigned int *ppi)
> {
> struct device_node *np;
> int ret = -EINVAL;
> +#ifdef CONFIG_ACPI_GTDT
> + struct arch_timer_data data;
> +#endif
>
> np = of_find_matching_node(NULL, arch_timer_of_match);
> if (!np) {
> @@ -397,6 +400,11 @@ static int kvm_timer_get_ppi(unsigned int *ppi)
> of_node_put(np);
>
> skip_of:
> +#ifdef CONFIG_ACPI_GTDT
> + if (!*ppi && !gtdt_arch_timer_data_init(NULL, &data))
> + *ppi = data.virt_ppi;
> +#endif
> +
> if (*ppi)
> return 0;
>
>
As I already pointed out in another thread hacking some KVM ACPI stuff,
this is the wrong approach.
We should have a *common* accessor in the timer code that exports the
relevant information, whatever the firmware "du jour" is.
See Julien's series, which seems to address the issue in a much more
convincing way:
https://lists.cs.columbia.edu/pipermail/kvmarm/2016-February/018531.html
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2016-02-08 17:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 20:26 [PATCH v3 0/6] acpi, clocksource, kvm: add GTDT and ARM memory-mapped timer support fu.wei at linaro.org
2016-02-01 20:26 ` [PATCH v3 1/6] ACPI: add GTDT table parse driver into ACPI driver fu.wei at linaro.org
2016-02-01 20:26 ` [PATCH v3 2/6] clocksource: simplify ACPI code in arm_arch_timer.c fu.wei at linaro.org
2016-02-01 20:26 ` [PATCH v3 3/6] clocksource: add memory-mapped timer support " fu.wei at linaro.org
2016-02-01 20:26 ` [PATCH v3 4/6] clocksource: move some enums to arm_arch_timer.h fu.wei at linaro.org
2016-02-01 20:26 ` [PATCH v3 5/6] kvm: arm64: wrapping DT support for virt arch timer fu.wei at linaro.org
2016-02-01 20:26 ` [PATCH v3 6/6] kvm: arm64: Add ACPI " fu.wei at linaro.org
2016-02-07 13:30 ` kbuild test robot
2016-02-08 17:10 ` Marc Zyngier [this message]
2016-02-21 16:35 ` Fu Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B8CBE8.7020305@arm.com \
--to=marc.zyngier@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox