From: m-karicheri2@ti•com (Murali Karicheri)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/5] drivers/pci: make host/pci-keystone-dw.c modular
Date: Mon, 8 Feb 2016 14:03:07 -0500 [thread overview]
Message-ID: <56B8E66B.3060309@ti.com> (raw)
In-Reply-To: <20160208155324.GU23093@windriver.com>
On 02/08/2016 10:53 AM, Paul Gortmaker wrote:
> [Re: [PATCH 4/5] drivers/pci: make host/pci-keystone-dw.c modular] On 08/02/2016 (Mon 10:59) Arnd Bergmann wrote:
>
>> On Sunday 07 February 2016 19:00:43 Paul Gortmaker wrote:
>>> Export the symbols that this driver requires in order for it to
>>> be modular. In addition to the one use case of a dw_pci sym, it
>>> has many instances of its own ks_dw_pci syms that need exporting
>>> in order to modpost w/o error.
>>>
>>> Cc: Murali Karicheri <m-karicheri2@ti•com>
>>> Cc: Bjorn Helgaas <bhelgaas@google•com>
>>> Cc: Stanimir Varbanov <svarbanov@mm-sol•com>
>>> Cc: Geert Uytterhoeven <geert+renesas@glider•be>
>>> Cc: Thierry Reding <thierry.reding@gmail•com>
>>> Cc: Arnd Bergmann <arnd@arndb•de>
>>> Cc: linux-pci at vger.kernel.org
>>> Cc: linux-arm-kernel at lists.infradead.org
>>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com>
>>> ---
>>
>>
>> Could we just have one module for the driver instead of two?
I agree. Please note that Keystone PCI is tested only as static.
I can help test the module if this series get to the next revision,
but it might be a while before I can do the test.
Murali
>
> That thought crossed my mind, but I was considering merging the C files
> and figured it might be more churn than the maintainer wanted. If
> maintainers are good with the below (assuming it works) then yes that
> also seems reasonable.
>
> P.
> --
>
>>
>> Something like below (untested)
>>
>> Arnd
>>
>> diff --git a/drivers/pci/host/Makefile b/drivers/pci/host/Makefile
>> index 7b2f20c6ccc6..0b472c680348 100644
>> --- a/drivers/pci/host/Makefile
>> +++ b/drivers/pci/host/Makefile
>> @@ -8,7 +8,8 @@ obj-$(CONFIG_PCI_RCAR_GEN2) += pci-rcar-gen2.o
>> obj-$(CONFIG_PCI_RCAR_GEN2_PCIE) += pcie-rcar.o
>> obj-$(CONFIG_PCI_HOST_GENERIC) += pci-host-generic.o
>> obj-$(CONFIG_PCIE_SPEAR13XX) += pcie-spear13xx.o
>> -obj-$(CONFIG_PCI_KEYSTONE) += pci-keystone-dw.o pci-keystone.o
>> +obj-$(CONFIG_PCI_KEYSTONE) pci-keystone-mod.o
>> +pci-keystone-mod-objs := pci-keystone-dw.o pci-keystone.o
>> obj-$(CONFIG_PCIE_XILINX) += pcie-xilinx.o
>> obj-$(CONFIG_PCI_XGENE) += pci-xgene.o
>> obj-$(CONFIG_PCI_XGENE_MSI) += pci-xgene-msi.o
>>
>
--
Murali Karicheri
Linux Kernel, Keystone
next prev parent reply other threads:[~2016-02-08 19:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 0:00 [PATCH 0/5] Modularize PCI_DW related drivers Paul Gortmaker
2016-02-08 0:00 ` [PATCH 1/5] ARM: add EXPORT_SYMBOL of hook_fault_code for PCI host modularization Paul Gortmaker
2016-02-08 9:53 ` Arnd Bergmann
2016-02-08 16:39 ` Paul Gortmaker
2016-02-08 17:27 ` Russell King - ARM Linux
2016-02-08 17:34 ` Russell King - ARM Linux
2016-02-08 0:00 ` [PATCH 4/5] drivers/pci: make host/pci-keystone-dw.c modular Paul Gortmaker
2016-02-08 9:59 ` Arnd Bergmann
2016-02-08 15:53 ` Paul Gortmaker
2016-02-08 19:03 ` Murali Karicheri [this message]
2016-02-24 6:09 ` [PATCH 0/5] Modularize PCI_DW related drivers Kishon Vijay Abraham I
2016-02-24 9:04 ` Arnd Bergmann
2016-02-25 8:13 ` Kishon Vijay Abraham I
2016-02-25 8:35 ` Arnd Bergmann
2016-02-29 9:29 ` Kishon Vijay Abraham I
2016-03-01 21:35 ` Arnd Bergmann
2016-03-15 20:50 ` Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B8E66B.3060309@ti.com \
--to=m-karicheri2@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox