From: robin.murphy@arm•com (Robin Murphy)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 3/8] dma-mapping: add dma_{map,unmap}_resource
Date: Wed, 10 Feb 2016 10:25:07 +0000 [thread overview]
Message-ID: <56BB1003.8020409@arm.com> (raw)
In-Reply-To: <1455065878-11906-4-git-send-email-niklas.soderlund+renesas@ragnatech.se>
Hi Niklas,
Thanks for doing this, it looks good. Just a couple of minor comments on
this and the next patch...
On 10/02/16 00:57, Niklas S?derlund wrote:
> Map/Unmap a device resource from a physical address. If no dma_map_ops
> method is available the operation is a no-op.
>
> Signed-off-by: Niklas S?derlund <niklas.soderlund+renesas@ragnatech•se>
> ---
> include/linux/dma-mapping.h | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
> index e3aba4e..21bf986 100644
> --- a/include/linux/dma-mapping.h
> +++ b/include/linux/dma-mapping.h
> @@ -216,6 +216,33 @@ static inline void dma_unmap_page(struct device *dev, dma_addr_t addr,
> debug_dma_unmap_page(dev, addr, size, dir, false);
> }
>
> +static inline dma_addr_t dma_map_resource(struct device *dev,
> + phys_addr_t phys_addr,
> + size_t size,
> + enum dma_data_direction dir,
> + struct dma_attrs *attrs)
> +{
> + struct dma_map_ops *ops = get_dma_ops(dev);
> +
> + BUG_ON(!valid_dma_direction(dir));
I think it would be worth also having the same inverse pfn_valid() check
as ioremap() here, to make sure this is similarly hard to misuse.
Robin.
> + if (ops->map_resource)
> + return ops->map_resource(dev, phys_addr, size, dir, attrs);
> +
> + return phys_addr;
> +}
> +
> +static inline void dma_unmap_resource(struct device *dev, dma_addr_t addr,
> + size_t size, enum dma_data_direction dir,
> + struct dma_attrs *attrs)
> +{
> + struct dma_map_ops *ops = get_dma_ops(dev);
> +
> + BUG_ON(!valid_dma_direction(dir));
> + if (ops->unmap_resource)
> + ops->unmap_resource(dev, addr, size, dir, attrs);
> +
> +}
> +
> static inline void dma_sync_single_for_cpu(struct device *dev, dma_addr_t addr,
> size_t size,
> enum dma_data_direction dir)
>
next prev parent reply other threads:[~2016-02-10 10:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 0:57 [PATCH v3 0/8] dmaengine: rcar-dmac: add iommu support for slave transfers Niklas Söderlund
2016-02-10 0:57 ` [PATCH v3 1/8] iommu: Add MMIO mapping type Niklas Söderlund
2016-02-11 0:02 ` Laurent Pinchart
2016-02-11 15:57 ` Robin Murphy
2016-02-16 12:06 ` Niklas Söderlund
2016-02-16 12:43 ` Robin Murphy
2016-02-16 13:30 ` Niklas Söderlund
2016-02-10 0:57 ` [PATCH v3 2/8] dma-mapping: add {map,unmap}_resource to dma_map_ops Niklas Söderlund
2016-02-10 12:11 ` Sergei Shtylyov
2016-02-11 0:03 ` [PATCH v3 2/8] dma-mapping: add {map, unmap}_resource " Laurent Pinchart
2016-02-10 0:57 ` [PATCH v3 3/8] dma-mapping: add dma_{map,unmap}_resource Niklas Söderlund
2016-02-10 10:25 ` Robin Murphy [this message]
2016-02-10 0:57 ` [PATCH v3 4/8] arm: dma-mapping: add {map, unmap}_resource for iommu ops Niklas Söderlund
2016-02-11 0:12 ` Laurent Pinchart
2016-02-10 0:57 ` [PATCH v3 5/8] dmaengine: rcar-dmac: group slave configuration Niklas Söderlund
2016-02-11 0:14 ` Laurent Pinchart
2016-02-10 0:57 ` [PATCH v3 6/8] dmaengine: rcar-dmac: add iommu support for slave transfers Niklas Söderlund
2016-02-10 10:49 ` Robin Murphy
2016-02-11 0:33 ` Laurent Pinchart
2016-02-10 0:57 ` [PATCH v3 7/8] ARM: dts: r8a7790: add iommus to dmac0 and dmac1 Niklas Söderlund
2016-02-10 17:55 ` Simon Horman
2016-02-11 0:50 ` Niklas Söderlund
2016-02-11 0:41 ` Laurent Pinchart
2016-02-10 0:57 ` [PATCH v3 8/8] ARM: dts: r8a7791: " Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BB1003.8020409@arm.com \
--to=robin.murphy@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox