From: linux@roeck-us•net (Guenter Roeck)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v12 4/4] Watchdog: introduce ARM SBSA watchdog driver
Date: Tue, 16 Feb 2016 07:29:58 -0800 [thread overview]
Message-ID: <56C34076.1020206@roeck-us.net> (raw)
In-Reply-To: <1455611785-2407-5-git-send-email-fu.wei@linaro.org>
On 02/16/2016 12:36 AM, fu.wei at linaro.org wrote:
> From: Fu Wei <fu.wei@linaro•org>
>
> According to Server Base System Architecture (SBSA) specification,
> the SBSA Generic Watchdog has two stage timeouts: the first signal (WS0)
> is for alerting the system by interrupt, the second one (WS1) is a real
> hardware reset.
> More details about the hardware specification of this device:
> ARM DEN0029B - Server Base System Architecture (SBSA)
>
> This driver can operate ARM SBSA Generic Watchdog as a single stage watchdog
> or a two stages watchdog, it's set up by the module parameter "action".
> In the single stage mode, when the timeout is reached, your system
> will be reset by WS1. The first signal (WS0) is ignored.
> In the two stages mode, when the timeout is reached, the first signal (WS0)
> will trigger panic. If the system is getting into trouble and cannot be reset
> by panic or restart properly by the kdump kernel(if supported), then the
> second stage (as long as the first stage) will be reached, system will be
> reset by WS1. This function can help administrator to backup the system
> context info by panic console output or kdump.
>
> This driver bases on linux kernel watchdog framework, so it can get
> timeout from module parameter and FDT at the driver init stage.
>
> Signed-off-by: Fu Wei <fu.wei@linaro•org>
> Reviewed-by: Graeme Gregory <graeme.gregory@linaro•org>
> Tested-by: Pratyush Anand <panand@redhat•com>
> Acked-by: Timur Tabi <timur@codeaurora•org>
> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro•org>
> ---
> drivers/watchdog/Kconfig | 20 +++
> drivers/watchdog/Makefile | 1 +
> drivers/watchdog/sbsa_gwdt.c | 403 +++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 424 insertions(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 0f6d851..ed9a5cb 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
[ ... ]
> +
> +static int sbsa_gwdt_probe(struct platform_device *pdev)
> +{
[ ... ]
> + if (!action)
> + dev_warn(dev, "falling back to signle stage mode.\n");
Still:
s/signle/single/
[ ... ]
> +
> +MODULE_DESCRIPTION("SBSA Generic Watchdog Driver");
> +MODULE_AUTHOR("Fu Wei <fu.wei@linaro•org>");
> +MODULE_AUTHOR("Suravee Suthikulpanit <Suravee.Suthikulpanit@amd•com>");
> +MODULE_AUTHOR("Al Stone <al.stone@linaro•org>");
> +MODULE_AUTHOR("Timur Tabi <timur@codeaurora•org>");
> +MODULE_LICENSE("GPL v2");
>
Do you need a MODULE_ALIAS ?
Guenter
next prev parent reply other threads:[~2016-02-16 15:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 8:36 [PATCH v12 0/4] Watchdog: introduce ARM SBSA watchdog driver fu.wei at linaro.org
2016-02-16 8:36 ` [PATCH v12 1/4] Documentation: add sbsa-gwdt driver documentation fu.wei at linaro.org
2016-02-16 15:30 ` Guenter Roeck
2016-02-16 8:36 ` [PATCH v12 2/4] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts fu.wei at linaro.org
2016-02-16 15:31 ` Guenter Roeck
2016-02-16 8:36 ` [PATCH v12 3/4] ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi fu.wei at linaro.org
2016-02-16 15:31 ` Guenter Roeck
2016-02-16 8:36 ` [PATCH v12 4/4] Watchdog: introduce ARM SBSA watchdog driver fu.wei at linaro.org
2016-02-16 15:29 ` Guenter Roeck [this message]
2016-02-16 15:54 ` Fu Wei
2016-02-16 16:33 ` Fu Wei
2016-02-17 0:09 ` Guenter Roeck
2016-02-26 19:27 ` Timur Tabi
2016-02-28 14:01 ` Fu Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C34076.1020206@roeck-us.net \
--to=linux@roeck-us$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox