From: javier@osg•samsung.com (Javier Martinez Canillas)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] ARM: dts: Move syscon reboot/poweroff to common dtsi for Exynos
Date: Tue, 16 Feb 2016 23:23:24 -0300 [thread overview]
Message-ID: <56C3D99C.3090403@osg.samsung.com> (raw)
In-Reply-To: <56C3D745.7050904@samsung.com>
Hello Krzysztof,
On 02/16/2016 11:13 PM, Krzysztof Kozlowski wrote:
[snip]
>> diff --git a/arch/arm/boot/dts/exynos-syscon-restart.dtsi b/arch/arm/boot/dts/exynos-syscon-restart.dtsi
>> new file mode 100644
>> index 000000000000..09a2040054ed
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/exynos-syscon-restart.dtsi
>> @@ -0,0 +1,27 @@
>> +/*
>> + * Samsung's Exynos SoC syscon reboot/poweroff nodes common definition.
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + */
>> +
>> +/ {
>> + soc {
>> + compatible = "simple-bus";
>
> The exynos4 does not have soc node. I wonder whether we should provide
> here also address and size:
> #address-cells = <1>;
> #size-cells = <1>;
> ranges;
>
> Without this it works fine but that does not look correct enough.
>
> A minor effect of this patch on Exynos4 is that syscon-poweroff/reboot
> are now the only children of "soc" simple-bus (rest of platform devices
> is not)... but this is not a problem.
>
> Works fine so only the question about cells/ranges remains. Any comments?
>
I in fact had the #address-cells and #size-cells at the beginning but then
realized that both the syscon-poweroff and syscon-reboot nodes didn't have
a reg property so it felt strange to me to have those.
Also, I thought that maybe a SoC dtsi may need a different #address-cells
and #size-cells for the other child nodes so having those in this dtsi
could override the values in the SoC dtsi depending where is included.
So I thought it could do more harm than good but I've no strong opinion
and can add those if you prefer.
> Best regards,
> Krzysztof
>
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2016-02-17 2:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 15:25 [PATCH v2] ARM: dts: Move syscon reboot/poweroff to common dtsi for Exynos Javier Martinez Canillas
2016-02-17 2:13 ` Krzysztof Kozlowski
2016-02-17 2:23 ` Javier Martinez Canillas [this message]
2016-02-23 0:18 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C3D99C.3090403@osg.samsung.com \
--to=javier@osg$(echo .)samsung.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox