From: michael.hennerich@analog•com (Michael Hennerich)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 07/61] gpio: adp5588: Use devm_gpiochip_add_data() for gpio registration
Date: Tue, 23 Feb 2016 08:49:21 +0100 [thread overview]
Message-ID: <56CC0F01.1000006@analog.com> (raw)
In-Reply-To: <1456150130-2668-8-git-send-email-ldewangan@nvidia.com>
On 02/22/2016 03:07 PM, Laxman Dewangan wrote:
> Use devm_gpiochip_add_data() for GPIO registration and remove the
> call for gpiochip_remove() from remove callback.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia•com>
Acked-by: Michael Hennerich <michael.hennerich@analog•com>
> Cc: Michael Hennerich <michael.hennerich@analog•com>
> ---
> drivers/gpio/gpio-adp5588.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-adp5588.c b/drivers/gpio/gpio-adp5588.c
> index 19a0eba..c0f718b 100644
> --- a/drivers/gpio/gpio-adp5588.c
> +++ b/drivers/gpio/gpio-adp5588.c
> @@ -414,7 +414,7 @@ static int adp5588_gpio_probe(struct i2c_client *client,
> }
> }
>
> - ret = gpiochip_add_data(&dev->gpio_chip, dev);
> + ret = devm_gpiochip_add_data(&client->dev, &dev->gpio_chip, dev);
> if (ret)
> goto err_irq;
>
> @@ -457,8 +457,6 @@ static int adp5588_gpio_remove(struct i2c_client *client)
> if (dev->irq_base)
> free_irq(dev->client->irq, dev);
>
> - gpiochip_remove(&dev->gpio_chip);
> -
> return 0;
> }
>
>
--
Greetings,
Michael
--
Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif
next prev parent reply other threads:[~2016-02-23 7:49 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 14:07 [PATCH 00/61] gpio: Add and use devm_gpiochip_add_data() Laxman Dewangan
2016-02-22 14:07 ` [PATCH 01/61] gpio: Add devm_ apis for gpiochip_add_data and gpiochip_remove Laxman Dewangan
2016-02-22 14:32 ` Andrew Lunn
2016-02-22 14:07 ` [PATCH 02/61] gpio: Add resource management devm_gpio_chip_{add_data, remove} Laxman Dewangan
2016-02-22 14:07 ` [PATCH 03/61] gpio: Add missing devm_gpio_ wrapper in devres.txt Laxman Dewangan
2016-02-22 14:07 ` [PATCH 04/61] gpio: 74xx-mmio: Use devm_gpiochip_add_data() for gpio registration Laxman Dewangan
2016-02-22 14:07 ` [PATCH 05/61] gpio: adnp: " Laxman Dewangan
2016-02-22 14:07 ` [PATCH 06/61] gpio: adp5520: " Laxman Dewangan
2016-02-23 7:49 ` Michael Hennerich
2016-02-22 14:07 ` [PATCH 07/61] gpio: adp5588: " Laxman Dewangan
2016-02-23 7:49 ` Michael Hennerich [this message]
2016-02-22 14:07 ` [PATCH 08/61] gpio: amdpt: " Laxman Dewangan
2016-02-22 14:07 ` [PATCH 09/61] gpio: arizona: " Laxman Dewangan
2016-02-22 16:28 ` Charles Keepax
2016-02-22 14:07 ` [PATCH 10/61] gpio: ath79: " Laxman Dewangan
2016-02-22 20:13 ` Alban
2016-02-23 14:58 ` Laxman Dewangan
2016-02-22 14:08 ` [PATCH 11/61] gpio: bcm-kona: " Laxman Dewangan
2016-02-22 17:17 ` Ray Jui
2016-02-22 14:08 ` [PATCH 12/61] gpio: clps711x: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 13/61] gpio: crystalcove: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 14/61] gpio: cs5535: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 15/61] gpio: da9052: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 16/61] gpio: da9055: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 17/61] gpio: dln2: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 18/61] gpio: ep93xx: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 19/61] gpio: f7188x: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 20/61] gpio: ge: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 21/61] gpio: generic: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 22/61] gpio: iop: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 23/61] gpio: janz-ttl: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 24/61] gpio: kempld: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 25/61] gpio: lp3943: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 26/61] gpio: lpc32xx: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 27/61] gpio: lynxpoint: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 28/61] gpio: mc9s08dz60: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 29/61] gpio: moxart: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 30/61] gpio: mvebu: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 31/61] gpio: mxc: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 32/61] gpio: octeon: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 33/61] gpio: pca953x: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 34/61] gpio: pcf857x: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 35/61] gpio: palmas: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 36/61] gpio: rc5t583: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 37/61] gpio: rdc321x: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 38/61] gpio: sch: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 39/61] gpio: spear-spics: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 40/61] gpio: sta2x11: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 41/61] gpio: stp-xway: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 42/61] gpio: sx150x: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 43/61] gpio: syscon: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 44/61] gpio: tb10x: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 45/61] gpio: tc3589x: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 46/61] gpio: tegra: " Laxman Dewangan
2016-02-23 16:30 ` Thierry Reding
2016-02-22 14:08 ` [PATCH 47/61] gpio: timberdale " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 48/61] gpio: tps6586x: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 49/61] gpio: tps65910: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 50/61] gpio: tps65912: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 51/61] gpio: ts4800: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 52/61] gpio: ts5500: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 53/61] gpio: twl6040: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 54/61] gpio: ucb1400: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 55/61] gpio: viperboard: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 56/61] gpio: vx855: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 57/61] gpio: wm8350: " Laxman Dewangan
2016-02-22 16:29 ` Charles Keepax
2016-02-22 14:08 ` [PATCH 58/61] " Laxman Dewangan
2016-02-22 16:29 ` Charles Keepax
2016-02-22 14:08 ` [PATCH 59/61] gpio: wm8994: " Laxman Dewangan
2016-02-22 16:29 ` Charles Keepax
2016-02-22 14:08 ` [PATCH 60/61] gpio: xgene-sb: " Laxman Dewangan
2016-02-22 14:08 ` [PATCH 61/61] gpio: xgene: " Laxman Dewangan
2016-02-22 14:44 ` [PATCH 00/61] gpio: Add and use devm_gpiochip_add_data() Linus Walleij
2016-02-23 9:01 ` Laxman Dewangan
2016-02-23 15:15 ` Laxman Dewangan
2016-02-25 13:24 ` Linus Walleij
2016-02-28 14:32 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC0F01.1000006@analog.com \
--to=michael.hennerich@analog$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox