From: andre.przywara@arm•com (André Przywara)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] clk: sunxi: allow PLL6 clock to be reused
Date: Thu, 25 Feb 2016 20:58:05 +0000 [thread overview]
Message-ID: <56CF6ADD.1000803@arm.com> (raw)
In-Reply-To: <20160225181105.GE4736@lukather>
On 25/02/16 18:11, Maxime Ripard wrote:
> On Mon, Feb 22, 2016 at 09:38:53AM +0000, Andre Przywara wrote:
>>>> diff --git a/drivers/clk/sunxi/clk-factors.h b/drivers/clk/sunxi/clk-factors.h
>>>> index 1e63c5b..3a7da86 100644
>>>> --- a/drivers/clk/sunxi/clk-factors.h
>>>> +++ b/drivers/clk/sunxi/clk-factors.h
>>>> @@ -36,6 +36,7 @@ struct factors_data {
>>>> void (*getter)(struct factors_request *req);
>>>> void (*recalc)(struct factors_request *req);
>>>> const char *name;
>>>> + int name_idx;
>>>
>>> I would drop the .name field. It was a bad workaround
>>> due to limitations of the factors clk code at the time
>>> by me. We really shouldn't hard-code the name if we want
>>> to reuse the driver.
>>
>> I know what you mean (my first thought, too) and I totally agree, but we
>> need it still for PLL5, which does not carry the original name in the DT
>> output names.
>> So at least this workaround here does not work, I guess we have to come
>> up with something different - which would be a different patch.
>> I can take a look into this later.
>
> Actually, it could be easily worked around. Always take the first
> clock output name, take whatever is before '_', and you can remove the
> name field entirely.
Yeah, I was thinking about that, too, but wanted to give an easy patch a
try first.
> Jens did something along these lines here:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/379900.html
Indeed, I stumbled upon this by accident today. Looks great on the first
glance: using .self first, then the stub till the underscore. I can
review and test this, if needed.
> Maybe we should simply rebase this patch, and remove the part that
> falls back on the name field.
I am totally fine with this!
Thanks!
Andre.
prev parent reply other threads:[~2016-02-25 20:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 1:39 [PATCH] clk: sunxi: allow PLL6 clock to be reused Andre Przywara
2016-02-22 8:08 ` Chen-Yu Tsai
2016-02-22 9:38 ` Andre Przywara
2016-02-25 18:11 ` Maxime Ripard
2016-02-25 20:58 ` André Przywara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CF6ADD.1000803@arm.com \
--to=andre.przywara@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox