From: vigneshr@ti•com (Vignesh R)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: dts: dra7: Support QSPI MODE-0 operation at 64MHz
Date: Mon, 29 Feb 2016 17:22:45 +0530 [thread overview]
Message-ID: <56D4310D.5020608@ti.com> (raw)
In-Reply-To: <20160226191342.GF13417@atomide.com>
Hi,
On 02/27/2016 12:43 AM, Tony Lindgren wrote:
> Hi,
>
> * Vignesh R <vigneshr@ti•com> [160224 20:49]:
>> According to Data Manual(SPRS915P) of AM57x, TI QSPI controller on
>> DRA74(rev 1.1+) can support up to 64MHz in MODE-0, whereas MODE-3 is
>> limited to 48MHz. Hence, switch to MODE-0 for better throughput.
>>
>> Signed-off-by: Vignesh R <vigneshr@ti•com>
>> ---
>> arch/arm/boot/dts/dra7-evm.dts | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
>> index cfc24e52244e..15f10bdc8c31 100644
>> --- a/arch/arm/boot/dts/dra7-evm.dts
>> +++ b/arch/arm/boot/dts/dra7-evm.dts
>> @@ -653,15 +653,13 @@
>> pinctrl-names = "default";
>> pinctrl-0 = <&qspi1_pins>;
>>
>> - spi-max-frequency = <48000000>;
>> + spi-max-frequency = <64000000>;
>> m25p80 at 0 {
>> compatible = "s25fl256s1";
>> - spi-max-frequency = <48000000>;
>> + spi-max-frequency = <64000000>;
>> reg = <0>;
>> spi-tx-bus-width = <1>;
>> spi-rx-bus-width = <4>;
>> - spi-cpol;
>> - spi-cpha;
>> #address-cells = <1>;
>> #size-cells = <1>;
>>
>
> Do we have any earlier pre DRA74(rev 1.1)versions in use too?
Yes, there are pre 1.1 boards (production boards are all rev 1.1+), but
QSPI is broken on them due to erratas (even w/o this patch).
>
> What about the spi-cpol and spi-cpha changes? Those should be
> at least documented?
>
Ok, I will add a NOTE in the documentation saying "spi-cpol" and
"spi-cpha" are not supported by ti-qspi in
Documentation/devicetree/bindings/spi/ti_qspi.txt.
--
Regards
Vignesh
prev parent reply other threads:[~2016-02-29 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 4:47 [PATCH] ARM: dts: dra7: Support QSPI MODE-0 operation at 64MHz Vignesh R
2016-02-26 19:13 ` Tony Lindgren
2016-02-29 11:52 ` Vignesh R [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D4310D.5020608@ti.com \
--to=vigneshr@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox