From: nicolas.ferre@atmel•com (Nicolas Ferre)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: dts: at91: sama5d2 Xplained: Correct the macb irq pinctrl node
Date: Tue, 1 Mar 2016 10:48:05 +0100 [thread overview]
Message-ID: <56D56555.1030703@atmel.com> (raw)
In-Reply-To: <1455790866-13301-1-git-send-email-romain.izard.pro@gmail.com>
Le 18/02/2016 11:21, Romain Izard a ?crit :
> All pinctrl nodes for the Atmel pinctrl controller need to have their
> bias configuration explicitly defined. Otherwise, the pinctrl mapping
> is not valid.
>
> It works for now as the pinctrl driver proceeds even with invalid
> mappings, but this can become an issue, if the pinctrl driver starts
> to require valid mappings. Additionally, the pin is not protected from
> being remapped later by an other driver.
>
> There is an external 1k? pull-up to 3.3V, so no bias is required on
> the Ethernet PHY's interrupt line.
>
> Signed-off-by: Romain Izard <romain.izard.pro@gmail•com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel•com>
And queued on at91-4.5-dt.
Thanks! Bye,
> ---
> arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> index e683856c507c..75341eec2dfd 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> @@ -308,6 +308,7 @@
>
> pinctrl_macb0_phy_irq: macb0_phy_irq {
> pinmux = <PIN_PC9__GPIO>;
> + bias-disable;
> };
>
> pinctrl_pdmic_default: pdmic_default {
>
--
Nicolas Ferre
prev parent reply other threads:[~2016-03-01 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 10:21 [PATCH] ARM: dts: at91: sama5d2 Xplained: Correct the macb irq pinctrl node Romain Izard
2016-02-19 13:19 ` Ludovic Desroches
2016-03-01 9:48 ` Nicolas Ferre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D56555.1030703@atmel.com \
--to=nicolas.ferre@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox