From: andre.przywara@arm•com (André Przywara)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node
Date: Wed, 2 Mar 2016 00:03:04 +0000 [thread overview]
Message-ID: <56D62DB8.2080301@arm.com> (raw)
In-Reply-To: <56D6264B.2090507@suse.de>
On 01/03/16 23:31, Andreas F?rber wrote:
> Hi,
>
> Am 01.03.2016 um 13:43 schrieb Andre Przywara:
>> On 01/03/16 11:18, Andreas F?rber wrote:
>>> Am 01.03.2016 um 12:01 schrieb Andre Przywara:
>>>> On 29/02/16 23:44, Andreas F?rber wrote:
>>>>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>>>>> index 0ae089bd1806..5088ae3ff653 100644
>>>>> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>>>>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>>>>> @@ -117,7 +117,9 @@
>>>>> gic: interrupt-controller at c4301000 {
>>>>> compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic";
>>>>
>>>> I think "arm,gic-400" is the name to use here these days, especially for
>>>> arm64.
>>>
>>> I took what /proc/device-tree showed on Android and verified that this
>>> compatible is in use in mainline.
>>
>> Some vendor Android kernel is not a good reference for mainline work ;-)
>> Better look at other DTs in arch/arm64/boot/dts.
>
> Yes, that's what "in use in mainline" refers to:
>
> $ git grep "cortex-a15-gic" -- arch/arm64/boot/dts/ | grep -v gic-400
> arch/arm64/boot/dts/apm/apm-shadowcat.dtsi: compatible =
> "arm,cortex-a15-gic";
> arch/arm64/boot/dts/apm/apm-storm.dtsi: compatible = "arm,cortex-a15-gic";
> arch/arm64/boot/dts/arm/foundation-v8.dts: compatible =
> "arm,cortex-a15-gic", "arm,cortex-a9-gic";
> arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts: compatible =
> "arm,cortex-a15-gic", "arm,cortex-a9-gic";
> arch/arm64/boot/dts/nvidia/tegra132.dtsi: compatible = "arm,cortex-a15-gic";
Which is mainly because those DTs predate the introduction of
"arm,gic-400". Other DTs kept the cortex strings in additionally to stay
compatible with older kernels.
>> You could keep "arm,cortex-a15-gic" in there if you care about
>> compatibility with older (vendor) kernels, but I guess there are other
>> issues which prevent this anyway, so you could drop this as well.
>
> Yeah, I don't care about backwards compatibility with downstream
> kernels, they use weird compatible strings with spaces anyway.
So please drop it and use only "arm,gic-400" to be in line with all the
other more recent SoCs.
Thanks!
Andre
next prev parent reply other threads:[~2016-03-02 0:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 23:44 [PATCH 0/8] ARM64: meson: GXBaby (S905) and Vega S95 enablement Andreas Färber
2016-02-29 23:44 ` [PATCH 1/8] ARM64: Enable Amlogic Meson GXBaby platform Andreas Färber
2016-03-01 14:43 ` Sudeep Holla
2016-03-01 15:26 ` Andreas Färber
2016-03-01 16:07 ` Sudeep Holla
2016-02-29 23:44 ` [PATCH 2/8] Documentation: devicetree: amlogic: Document Meson GXBaby Andreas Färber
2016-02-29 23:44 ` [PATCH 3/8] ARM64: dts: Prepare configs for Amlogic " Andreas Färber
2016-03-01 14:43 ` Sudeep Holla
2016-03-01 15:18 ` Andreas Färber
2016-03-01 16:19 ` Sudeep Holla
2016-02-29 23:44 ` [PATCH 4/8] Documentation: devicetree: Document Tronsmart vendor prefix Andreas Färber
2016-03-01 11:37 ` Matthias Brugger
2016-03-01 11:53 ` Andreas Färber
2016-03-01 13:29 ` Matthias Brugger
2016-03-01 19:23 ` Beniamino Galvani
2016-03-03 23:57 ` Rob Herring
2016-02-29 23:44 ` [PATCH 5/8] Documentation: devicetree: amlogic: Document Tronsmart Vega S95 boards Andreas Färber
2016-02-29 23:44 ` [PATCH 6/8] ARM64: dts: amlogic: Add Tronsmart Vega S95 configs Andreas Färber
2016-02-29 23:55 ` Andreas Färber
2016-02-29 23:44 ` [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node Andreas Färber
2016-03-01 11:01 ` Andre Przywara
2016-03-01 11:18 ` Andreas Färber
2016-03-01 11:42 ` Matthias Brugger
2016-03-01 12:43 ` Andre Przywara
2016-03-01 12:53 ` Carlo Caione
2016-03-01 14:16 ` Andre Przywara
2016-03-01 22:46 ` Andreas Färber
2016-03-01 22:58 ` André Przywara
2016-03-01 23:31 ` Andreas Färber
2016-03-02 0:03 ` André Przywara [this message]
2016-03-02 0:07 ` Andreas Färber
2016-02-29 23:44 ` [PATCH 8/8] ARM64: dts: amlogic: Add arch timer node for Meson GXBaby Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D62DB8.2080301@arm.com \
--to=andre.przywara@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox