From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull" parsing
Date: Thu, 3 Mar 2016 14:09:22 -0700 [thread overview]
Message-ID: <56D8A802.8040307@wwwdotorg.org> (raw)
In-Reply-To: <1456795808-1449-1-git-send-email-eric@anholt.net>
On 02/29/2016 06:30 PM, Eric Anholt wrote:
> From: Phil Elwell <phil@raspberrypi•org>
>
> The DT bindings for pinctrl-bcm2835 allow both the function and pull
> to contain either one entry or one per pin. However, an error in the
> DT parsing can cause failures if the number of pulls differs from the
> number of functions.
>
> Signed-off-by: Eric Anholt <eric@anholt•net>
> Cc: stable at vger.kernel.org
> ---
>
> Yes, the s-o-b differs from the author of the commit, but this falls
> under part b) of the process.
I'd argue that part (b) only applies if the s-o-b line is present in the
original, otherwise I'm not sure how it's clear the author intended to
publish their source under the license in question. That's why I've
always beedn careful to go back and ask the original author to give
their s-o-b, like you did. Some commits at least in the earlier Pi
Foundation kernels also clearly had incorrect git author values, or were
squashed together forms of multiple peoples' work:-(
Luckily it's a moot point since Phil gave his s-o-b.
Reviewed-by: Stephen Warren <swarren@wwwdotorg•org>
Does a similar bug exist in any other pinctrl drivers?
next prev parent reply other threads:[~2016-03-03 21:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 1:30 [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull" parsing Eric Anholt
2016-03-01 9:13 ` Phil Elwell
2016-03-03 21:09 ` Stephen Warren [this message]
2016-03-08 8:18 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D8A802.8040307@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox