From: fcooper@ti•com (Franklin S Cooper Jr.)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS
Date: Thu, 3 Mar 2016 19:39:22 -0600 [thread overview]
Message-ID: <56D8E74A.6090601@ti.com> (raw)
In-Reply-To: <20160302182634.GA26055@rob-hp-laptop>
Hi Rob,
On 03/02/2016 12:26 PM, Rob Herring wrote:
> On Thu, Feb 25, 2016 at 04:36:36PM -0600, Franklin S Cooper Jr wrote:
>> From: Vignesh R <vigneshr@ti•com>
>>
>> Add PWMSS device tree nodes for DRA7 SoC family and add documentation
>> for dt bindings.
>>
>> Signed-off-by: Vignesh R <vigneshr@ti•com>
>> ---
>> Version 3 changes:
>> None
>>
>> .../devicetree/bindings/pwm/pwm-tiehrpwm.txt | 8 +++
>> .../devicetree/bindings/pwm/pwm-tipwmss.txt | 17 +++++-
>> arch/arm/boot/dts/dra7.dtsi | 64 ++++++++++++++++++++++
>> 3 files changed, 88 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
>> index 9c100b2..25d91ae 100644
>> --- a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
>> +++ b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
>> @@ -4,6 +4,7 @@ Required properties:
>> - compatible: Must be "ti,<soc>-ehrpwm".
>> for am33xx - compatible = "ti,am33xx-ehrpwm";
>> for da850 - compatible = "ti,da850-ehrpwm", "ti,am33xx-ehrpwm";
>> + for dra7xx - compatible = "ti,dra7xx-ehrpwm", "ti,am33xx-ehrpwm";
> We're starting to push back on wildcards in compatible strings. I guess
> this is okay...
>
>> - #pwm-cells: should be 3. See pwm.txt in this directory for a description of
>> the cells format. The only third cell flag supported by this binding is
>> PWM_POLARITY_INVERTED.
>> @@ -27,3 +28,10 @@ ehrpwm0: ehrpwm at 0 { /* EHRPWM on da850 */
>> #pwm-cells = <3>;
>> reg = <0x300000 0x2000>;
>> };
>> +
>> +ehrpwm0: ehrpwm at 0 { /* EHRPWM on dra7xx */
> Should be pwm at 48440200
So the AM335x, AM437x and DA850 all use ehrpwm0:
ehrpwm@<address>. Also the address of 0 simply follows the
pattern used in the other binding examples in that doc. I
can replace the 0 address in this patch and make another
patch that fixes it for the other examples in that file. But
in terms of switching from ehrpwm0:ehrpwm@<address> to
ehrpwm0:pwm@<address> that would also require making changes
to the various dtsis also. So is it worth making that
change? If so I have no problem doing it.
>
>> + compatible = "ti,dra7xx-ehrpwm", "ti,am33xx-ehrpwm";
>> + #pwm-cells = <3>;
>> + reg = <0x48440200 0x80>;
>> + ti,hwmods = "ehrpwm0";
>> +};
next prev parent reply other threads:[~2016-03-04 1:39 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 22:36 [PATCH v3 0/5] Add support for PWMSS on DRA7 Franklin S Cooper Jr
2016-02-25 22:36 ` [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating Franklin S Cooper Jr
2016-02-26 10:27 ` Sekhar Nori
2016-02-26 19:14 ` Tony Lindgren
2016-02-29 22:04 ` Tony Lindgren
2016-02-29 22:30 ` Franklin S Cooper Jr.
2016-02-29 22:55 ` Tony Lindgren
2016-02-29 23:11 ` Franklin S Cooper Jr.
2016-02-29 23:20 ` Tony Lindgren
2016-03-02 19:41 ` Franklin S Cooper Jr.
2016-03-02 22:54 ` Tony Lindgren
2016-02-25 22:36 ` [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Franklin S Cooper Jr
2016-03-01 18:07 ` Paul Walmsley
2016-03-01 18:11 ` Tony Lindgren
2016-03-01 18:59 ` Paul Walmsley
2016-03-01 20:50 ` Tony Lindgren
2016-03-02 16:22 ` Franklin S Cooper Jr.
2016-03-04 2:07 ` Franklin S Cooper Jr.
2016-03-04 6:25 ` Paul Walmsley
2016-03-04 12:23 ` Franklin S Cooper Jr.
2016-03-04 16:32 ` Paul Walmsley
2016-02-25 22:36 ` [PATCH v3 3/5] ARM: dts: DRA7: Add TBCLK " Franklin S Cooper Jr
2016-02-29 23:23 ` Tony Lindgren
2016-03-01 12:54 ` Tero Kristo
2016-03-01 18:05 ` Tony Lindgren
2016-02-25 22:36 ` [PATCH v3 4/5] clk: ti: DRA7: Add tbclk data for ehrpwm Franklin S Cooper Jr
2016-02-26 19:16 ` Tony Lindgren
2016-02-26 19:17 ` Tony Lindgren
2016-02-25 22:36 ` [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Franklin S Cooper Jr
2016-02-26 19:18 ` Tony Lindgren
2016-02-26 19:43 ` Franklin S Cooper Jr
2016-02-29 23:24 ` Tony Lindgren
2016-03-01 21:00 ` Tony Lindgren
2016-03-02 18:26 ` Rob Herring
2016-03-04 1:39 ` Franklin S Cooper Jr. [this message]
2016-03-04 14:52 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D8E74A.6090601@ti.com \
--to=fcooper@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox