From: grygorii.strashko@ti•com (Grygorii Strashko)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] pinctrl: single: Use a separate lockdep class
Date: Tue, 8 Mar 2016 18:32:10 +0700 [thread overview]
Message-ID: <56DEB83A.9070901@ti.com> (raw)
In-Reply-To: <1454351299-27440-2-git-send-email-sudeep.holla@arm.com>
On 02/02/2016 01:28 AM, Sudeep Holla wrote:
> The single pinmux controller can be cascaded to the other interrupt
> controllers. Hence when propagating wake-up settings to its parent
> interrupt controller, there's possiblity of detecting possible recursive
> locking and getting lockdep warning.
>
> This patch avoids this false positive by using a separate lockdep class
> for this single pinctrl interrupts.
>
> Cc: Linus Walleij <linus.walleij@linaro•org>
> Cc: linux-gpio at vger.kernel.org
> Suggested-by: Thomas Gleixner <tglx@linutronix•de>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm•com>
> ---
> drivers/pinctrl/pinctrl-single.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> index d24e5f1d1525..fb126d56ad40 100644
> --- a/drivers/pinctrl/pinctrl-single.c
> +++ b/drivers/pinctrl/pinctrl-single.c
> @@ -255,6 +255,13 @@ static enum pin_config_param pcs_bias[] = {
> };
>
> /*
> + * This lock class tells lockdep that irqchip core that this single
> + * pinctrl can be in a different category than its parents, so it won't
> + * report false recursion.
> + */
> +static struct lock_class_key pcs_lock_class;
> +
> +/*
> * REVISIT: Reads and writes could eventually use regmap or something
> * generic. But at least on omaps, some mux registers are performance
> * critical as they may need to be remuxed every time before and after
> @@ -1713,6 +1720,7 @@ static int pcs_irqdomain_map(struct irq_domain *d, unsigned int irq,
> irq_set_chip_data(irq, pcs_soc);
> irq_set_chip_and_handler(irq, &pcs->chip,
> handle_level_irq);
> + irq_set_lockdep_class(irq, &pcs_lock_class);
> irq_set_noprobe(irq);
>
> return 0;
>
I have no objection to this patch and it's independent from other patches in
this series.
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti•com>
--
regards,
-grygorii
next prev parent reply other threads:[~2016-03-08 11:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 18:28 [PATCH 0/3] OMAP/pinmux: remove misuse of IRQF_NO_SUSPEND flag Sudeep Holla
2016-02-01 18:28 ` [PATCH 1/3] pinctrl: single: Use a separate lockdep class Sudeep Holla
2016-03-08 11:32 ` Grygorii Strashko [this message]
2016-03-11 16:04 ` Linus Walleij
2016-02-01 18:28 ` [PATCH 2/3] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag Sudeep Holla
2016-02-01 18:28 ` [PATCH 3/3] ARM: OMAP2+: " Sudeep Holla
2016-02-04 13:14 ` Grygorii Strashko
2016-02-04 13:34 ` Sudeep Holla
2016-02-13 14:42 ` [PATCH 0/3] OMAP/pinmux: " Linus Walleij
2016-02-15 10:01 ` Sudeep Holla
2016-02-15 15:27 ` Tony Lindgren
2016-03-08 11:31 ` Grygorii Strashko
2016-03-08 17:09 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DEB83A.9070901@ti.com \
--to=grygorii.strashko@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox