From: s.nawrocki@samsung•com (Sylwester Nawrocki)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 05/10] exynos4-is: Replace "hweight32(mask) == 1" with "is_power_of_2(mask)"
Date: Fri, 11 Mar 2016 17:28:21 +0100 [thread overview]
Message-ID: <56E2F225.3040109@samsung.com> (raw)
In-Reply-To: <1449398669-14507-1-git-send-email-zhaoxiu.zeng@gmail.com>
On 12/06/2015 11:44 AM, Zhaoxiu Zeng wrote:
> From: Zeng Zhaoxiu <zhaoxiu.zeng@gmail•com>
The patch looks OK, but could you also provide a proper commit
message?
> Signed-off-by: Zeng Zhaoxiu <zhaoxiu.zeng@gmail•com>
> ---
> drivers/media/platform/exynos4-is/fimc-is-regs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/exynos4-is/fimc-is-regs.c b/drivers/media/platform/exynos4-is/fimc-is-regs.c
> index cfe4406..ec75a24 100644
> --- a/drivers/media/platform/exynos4-is/fimc-is-regs.c
> +++ b/drivers/media/platform/exynos4-is/fimc-is-regs.c
> @@ -11,6 +11,7 @@
> * published by the Free Software Foundation.
> */
> #include <linux/delay.h>
> +#include <linux/log2.h>
>
> #include "fimc-is.h"
> #include "fimc-is-command.h"
> @@ -107,7 +108,7 @@ int fimc_is_hw_get_params(struct fimc_is *is, unsigned int num_args)
>
> void fimc_is_hw_set_isp_buf_mask(struct fimc_is *is, unsigned int mask)
> {
> - if (hweight32(mask) == 1) {
> + if (is_power_of_2(mask)) {
> dev_err(&is->pdev->dev, "%s(): not enough buffers (mask %#x)\n",
> __func__, mask);
> return;
--
Thanks,
Sylwester
prev parent reply other threads:[~2016-03-11 16:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-06 10:44 [PATCH 05/10] exynos4-is: Replace "hweight32(mask) == 1" with "is_power_of_2(mask)" Zhaoxiu Zeng
2016-03-11 16:28 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E2F225.3040109@samsung.com \
--to=s.nawrocki@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox