From: afaerber@suse•de (Andreas Färber)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 6/8] arm64: dts: rockchip: Add power key to GeekBox
Date: Wed, 16 Mar 2016 14:52:33 +0100 [thread overview]
Message-ID: <56E96521.40304@suse.de> (raw)
In-Reply-To: <56E93C43.1060500@suse.de>
Am 16.03.2016 um 11:58 schrieb Andreas F?rber:
> Am 11.03.2016 um 00:04 schrieb Julien Chauveau:
>>> @@ -70,6 +71,19 @@
>>> pinctrl-0 = <&ir_int>;
>>> };
>>>
>>> + keys: gpio-keys {
[...]
>>> + compatible = "gpio-keys";
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pwr_key>;
>>> +
>>> + button at 0 {
[...]
>>> + gpios = <&gpio0 2 GPIO_ACTIVE_LOW>;
>>> + label = "GPIO Power";
>>> + linux,code = <KEY_POWER>;
>>
>> According to Documentation/input/event-codes.txt, there?s a special event type for the power button.
>> Should we use it here for that purpose?
>>
>> linux,input-type = <EV_PWR>
>
> The other RK3368 boards don't, so unless you can give a justification to
> convert all boards yet again and test how this makes a difference, I'd
> rather not do experiments here but leave that to someone who knows what
> they're doing and then do it consistently...
For the record here's an evtest log:
geekbox:~ # evtest
No device specified, trying to scan all of /dev/input/event*
Available devices:
/dev/input/event0: gpio_ir_recv
/dev/input/event1: MCE IR Keyboard/Mouse (gpio-rc-recv)
/dev/input/event2: gpio-keys
Select the device event number [0-2]: 2
Input driver version is 1.0.1
Input device ID: bus 0x19 vendor 0x1 product 0x1 version 0x100
Input device name: "gpio-keys"
Supported events:
Event type 0 (EV_SYN)
Event type 1 (EV_KEY)
Event code 116 (KEY_POWER)
Properties:
Testing ... (interrupt to exit)
Event: time 1458136008.850429, type 1 (EV_KEY), code 116 (KEY_POWER),
value 1
Event: time 1458136008.850429, -------------- SYN_REPORT ------------
systemd then goes on to shut down the system cleanly.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N?rnberg)
next prev parent reply other threads:[~2016-03-16 13:52 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1457294038-14243-1-git-send-email-afaerber@suse.de>
2016-03-06 19:53 ` [PATCH v3 2/8] Documentation: devicetree: rockchip: Document GeekBox Andreas Färber
2016-03-06 19:53 ` [PATCH v3 3/8] arm64: dts: rockchip: Add GeekBox config Andreas Färber
2016-03-06 19:53 ` [PATCH v3 5/8] arm64: dts: rockchip: Clean up gpio-keys nodes Andreas Färber
2016-03-06 19:53 ` [PATCH v3 6/8] arm64: dts: rockchip: Add power key to GeekBox Andreas Färber
2016-03-10 23:04 ` Julien Chauveau
2016-03-16 10:58 ` Andreas Färber
2016-03-16 13:52 ` Andreas Färber [this message]
2016-03-10 23:09 ` Julien Chauveau
2016-03-06 19:53 ` [PATCH v3 7/8] Documentation: devicetree: rockchip: Document Landingship Andreas Färber
2016-03-17 14:46 ` Rob Herring
2016-03-06 19:53 ` [PATCH v3 8/8] arm64: dts: rockchip: Add Landingship config Andreas Färber
2016-03-07 12:17 ` [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement Andreas Färber
2016-03-07 12:24 ` Heiko Stübner
2016-03-07 12:35 ` Andreas Färber
2016-03-07 13:26 ` Giuseppe CAVALLARO
2016-03-07 14:27 ` Andreas Färber
2016-03-07 15:09 ` Giuseppe CAVALLARO
2016-03-07 15:46 ` Andreas Färber
2016-03-07 15:52 ` Giuseppe CAVALLARO
2016-03-07 17:15 ` Andreas Färber
2016-03-07 23:22 ` Dinh Nguyen
2016-03-08 7:24 ` Giuseppe CAVALLARO
2016-03-08 15:45 ` Dinh Nguyen
2016-03-09 7:24 ` Giuseppe CAVALLARO
2016-03-09 8:35 ` Tomeu Vizoso
2016-03-09 8:56 ` Giuseppe CAVALLARO
2016-03-09 9:00 ` Giuseppe CAVALLARO
2016-03-09 9:42 ` Tomeu Vizoso
2016-03-09 9:52 ` Giuseppe CAVALLARO
2016-03-09 10:27 ` Giuseppe CAVALLARO
2016-03-09 10:53 ` Tomeu Vizoso
2016-03-09 14:31 ` Giuseppe CAVALLARO
2016-03-09 14:53 ` Giuseppe CAVALLARO
2016-03-09 16:31 ` Dinh Nguyen
2016-03-10 9:13 ` Giuseppe CAVALLARO
2016-03-10 16:47 ` Dinh Nguyen
2016-03-11 9:09 ` Giuseppe CAVALLARO
2016-03-14 11:43 ` Tomeu Vizoso
2016-03-14 16:20 ` Giuseppe CAVALLARO
2016-03-15 7:23 ` Tomeu Vizoso
2016-03-15 12:36 ` Giuseppe CAVALLARO
2016-03-30 16:44 ` Dinh Nguyen
2016-03-31 7:53 ` Giuseppe CAVALLARO
2016-03-08 10:03 ` Gabriel Fernandez
2016-03-08 10:24 ` Giuseppe CAVALLARO
2016-03-08 10:33 ` Gabriel Fernandez
2016-03-11 12:12 ` Michael Trimarchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E96521.40304@suse.de \
--to=afaerber@suse$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox