From: sergei.shtylyov@cogentembedded•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/5] ARM: davinci: da8xx: add usb phy clocks
Date: Wed, 16 Mar 2016 21:04:11 +0300 [thread overview]
Message-ID: <56E9A01B.3010503@cogentembedded.com> (raw)
In-Reply-To: <56E99ECA.90400@lechnology.com>
On 03/16/2016 08:58 PM, David Lechner wrote:
>>> +static struct clk usb20_clk = {
>>> + .name = "usb20",
>>> + .parent = &pll0_sysclk2,
>>> + .lpsc = DA8XX_LPSC1_USB20,
>>> + .gpsc = 1,
>>> +};
>>
>> Why move it?
>
> For organization, to keep all of the USB clocks together. I can leave it alone
> if that is preferred.
I'd prefer to minimize the noise...
>>> +
>>> + /* Set the mux depending on the parent clock. */
>>> + if (clk->parent == &pll0_aux_clk)
>>> + val |= CFGCHIP2_USB2PHYCLKMUX;
>>> + else if (clk->parent == &usb_ref_clk)
>>> + val &= ~CFGCHIP2_USB2PHYCLKMUX;
>>
>> Don't we have clk_set_parent()for that?
>
> Yes. clk_set_parent() is already called in a loop for all clocks elsewhere, so
> not needed here.
No, I mean why is not this implemented as a part of clk_set_parent()?
MBR, Sergei
next prev parent reply other threads:[~2016-03-16 18:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 22:37 [PATCH 1/5] ARM: davinci: defined missing CFGCHIP2_REFFREQ_* macros for MUSB PHY David Lechner
2016-03-15 22:37 ` [PATCH 2/5] ARM: davinci: da8xx: add usb phy clocks David Lechner
2016-03-16 12:27 ` Sergei Shtylyov
2016-03-16 17:58 ` David Lechner
2016-03-16 18:04 ` Sergei Shtylyov [this message]
2016-03-16 18:21 ` David Lechner
2016-03-15 22:37 ` [PATCH 3/5] ARM: davinci: da8xx: add cfgchip2 to resources David Lechner
2016-03-15 22:45 ` Sergei Shtylyov
2016-03-16 3:46 ` David Lechner
2016-03-16 4:57 ` David Lechner
2016-03-16 17:38 ` Sergei Shtylyov
2016-03-16 18:14 ` David Lechner
2016-03-16 18:22 ` Sergei Shtylyov
2016-03-16 18:27 ` Sergei Shtylyov
2016-03-16 18:27 ` David Lechner
2016-03-16 11:34 ` Sergei Shtylyov
2016-03-15 22:37 ` [PATCH 4/5] usb: ohci-da8xx: Remove clock code that references mach David Lechner
2016-03-15 22:37 ` [PATCH 5/5] usb: musb-da8xx: remove board-specific clock handling David Lechner
2016-03-16 11:57 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E9A01B.3010503@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox