From: xf@rock-chips•com (Feng Xiao)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] cpufreq: rockchip: add driver
Date: Mon, 21 Mar 2016 21:24:32 +0800 [thread overview]
Message-ID: <56EFF610.6040402@rock-chips.com> (raw)
In-Reply-To: <20160321095855.GE27778@vireshk-i7>
? 2016/3/21 17:58, Viresh Kumar ??:
> On 21-03-16, 10:54, Heiko St?bner wrote:
>> I hadn't seen that yet ... nice that cpufreq-dt now also supports clusters :-)
>>
>> The other part still stands though, as we probably should register the
>> platform-device somewhere else and not in some new special module.
>>
>> When everything is using cpufreq-dt now, I guess we could just add it to the
>> core rockchip clk-code. Or was there some agreement where this should be done
>> (obviously not the devicetree itself)?
Of_clk_init is called early, and platform_device_register_simple should
be called after devices_init, it will be failed to do it from clk-code.
So we need add a new file or add module_init to each clock controller
driver(like clk-rk3368.c, clk-rk3399.c) ?
> Yeah, there was a discussion around creating a white or black list of platforms
> that want to create a platform device for cpufreq-dt. That can be done in
> cpufreq-dt.c or a new file, but I haven't worked out on that yet.
>
> You can do it from clk-code or from the driver that was added in this thread.
> Just that you need to match your platform's compatible string before doing that.
Rockchip-cpufreq.c depends on ARM_ROCKCHIP_CPUFREQ, it will not be
compiled on non-Rockchip platforms.
The driver can support all Rockchip SoCs up to now, add
of_machine_is_compatible may be redundant ?
>
next prev parent reply other threads:[~2016-03-21 13:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 12:10 [PATCH] cpufreq: rockchip: add driver Feng Xiao
2016-03-18 12:56 ` Heiko Stübner
2016-03-21 9:50 ` Viresh Kumar
2016-03-21 9:54 ` Heiko Stübner
2016-03-21 9:58 ` Viresh Kumar
2016-03-21 13:24 ` Feng Xiao [this message]
2016-03-21 15:13 ` Viresh Kumar
2016-03-21 15:13 ` Heiko Stübner
2016-03-21 15:52 ` Heiko Stübner
2016-03-22 1:28 ` Feng Xiao
2016-03-22 11:57 ` [PATCH v1] " Feng Xiao
2016-03-22 16:07 ` Heiko Stübner
2016-03-23 2:18 ` [PATCH v2] " Feng Xiao
2016-03-23 4:40 ` Viresh Kumar
2016-03-24 3:01 ` Feng Xiao
2016-03-24 6:43 ` Viresh Kumar
2016-03-24 15:09 ` Finley Xiao
2016-03-25 4:42 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EFF610.6040402@rock-chips.com \
--to=xf@rock-chips$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox