From: stefan.wahren@i2se•com (Stefan Wahren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: bcm2835: add CPU node for ARM core
Date: Tue, 29 Mar 2016 12:04:34 +0200 [thread overview]
Message-ID: <56FA5332.4050707@i2se.com> (raw)
In-Reply-To: <20160329094158.GB26574@leverpostej>
Am 29.03.2016 um 11:41 schrieb Mark Rutland:
> On Mon, Mar 28, 2016 at 04:21:20PM +0000, Stefan Wahren wrote:
>> This patch adds the CPU node of the BCM2835 into the DT.
>>
>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se•com>
>> ---
>> arch/arm/boot/dts/bcm2835.dtsi | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
>> index b83b326..e87aba1 100644
>> --- a/arch/arm/boot/dts/bcm2835.dtsi
>> +++ b/arch/arm/boot/dts/bcm2835.dtsi
>> @@ -3,6 +3,17 @@
>> / {
>> compatible = "brcm,bcm2835";
>>
>> + cpus {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + cpu at 0 {
>> + device_type = "cpu";
>> + compatible = "arm,arm1176jzf-s", "arm,arm1176";
>> + reg = <0x0>;
>> + };
>> + };
> Minor nit: the "arm,arm1176" fallback isn't documented, nor used
> elsewhere, so it can/should be dropped.
This fallback came from arch/arm/boot/dts/s3c64xx.dtsi
I will send a V2 without the fallback.
Stefan
>
> Otherwise, this looks fine per [1]. With the above change, feel free to
> add my ack.
>
> Mark.
>
> [1] Documentation/devicetree/bindings/arm/cpus.txt
>
>> +
>> soc {
>> ranges = <0x7e000000 0x20000000 0x02000000>;
>> dma-ranges = <0x40000000 0x00000000 0x20000000>;
>> --
>> 1.7.9.5
>>
next prev parent reply other threads:[~2016-03-29 10:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 16:21 [PATCH] ARM: bcm2835: add CPU node for ARM core Stefan Wahren
2016-03-28 19:36 ` Eric Anholt
2016-03-29 9:41 ` Mark Rutland
2016-03-29 10:04 ` Stefan Wahren [this message]
2016-03-29 10:13 ` Mark Rutland
2016-03-30 14:17 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FA5332.4050707@i2se.com \
--to=stefan.wahren@i2se$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox