From: vigneshr@ti•com (Vignesh R)
To: linux-arm-kernel@lists•infradead.org
Subject: [v2,4/7] scatterlist: add sg_alloc_table_from_buf() helper
Date: Thu, 31 Mar 2016 10:26:59 +0530 [thread overview]
Message-ID: <56FCAE1B.90206@ti.com> (raw)
In-Reply-To: <1459352394-22810-5-git-send-email-boris.brezillon@free-electrons.com>
Hi,
On 03/30/2016 09:09 PM, Boris BREZILLON wrote:
[...]
> +int sg_alloc_table_from_buf(struct sg_table *sgt, const void *buf, size_t len,
> + const struct sg_constraints *constraints,
> + gfp_t gfp_mask)
> +{
> + struct sg_constraints cons = { };
> + size_t remaining, chunk_len;
> + const void *sg_buf;
> + int i, ret;
> +
> + if (constraints)
> + cons = *constraints;
> +
> + ret = sg_check_constraints(&cons, buf, len);
> + if (ret)
> + return ret;
> +
> + sg_buf = buf;
> + remaining = len;
> + i = 0;
> + sg_for_each_chunk_in_buf(sg_buf, remaining, chunk_len, &cons)
> + i++;
> +
> + ret = sg_alloc_table(sgt, i, gfp_mask);
> + if (ret)
> + return ret;
> +
> + sg_buf = buf;
> + remaining = len;
> + i = 0;
> + sg_for_each_chunk_in_buf(sg_buf, remaining, chunk_len, &cons) {
> + if (is_vmalloc_addr(sg_buf)) {
> + struct page *vm_page;
> +
> + vm_page = vmalloc_to_page(sg_buf);
> + if (!vm_page) {
> + ret = -ENOMEM;
> + goto err_free_table;
> + }
> +
> + sg_set_page(&sgt->sgl[i], vm_page, chunk_len,
> + offset_in_page(sg_buf));
> + } else {
> + sg_set_buf(&sgt->sgl[i], sg_buf, chunk_len);
> + }
> +
If the buf address is in PKMAP_BASE - PAGE_OFFSET-1 region (I have
observed that JFFS2 FS provides buffers in above region to MTD layer),
if CONFIG_DEBUG_SG is set then sg_set_buf() will throw a BUG_ON() as
virt_addr_is_valid() will return false. Is there a sane way to handle
buffers of PKMAP_BASE region with sg_* APIs?
Or, is the function sg_alloc_table_from_buf() not to be used with such
buffers?
--
Regards
Vignesh
next prev parent reply other threads:[~2016-03-31 4:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 15:39 [PATCH v2 0/7] mtd: nand: sunxi: add support for DMA operations Boris Brezillon
2016-03-30 15:39 ` [PATCH v2 1/7] mtd: nand: sunxi: move some ECC related operations to their own functions Boris Brezillon
2016-03-30 15:39 ` [PATCH v2 2/7] mtd: nand: sunxi: make OOB retrieval optional Boris Brezillon
2016-03-30 15:39 ` [PATCH v2 3/7] mtd: nand: sunxi: make cur_off parameter optional in extra oob helpers Boris Brezillon
2016-03-30 15:39 ` [PATCH v2 4/7] scatterlist: add sg_alloc_table_from_buf() helper Boris Brezillon
2016-03-30 16:51 ` Mark Brown
2016-03-30 18:18 ` Boris Brezillon
2016-03-30 18:34 ` Mark Brown
2016-04-05 7:11 ` Dave Gordon
2016-03-31 4:56 ` Vignesh R [this message]
2016-03-31 7:26 ` [v2,4/7] " Boris Brezillon
2016-03-30 15:39 ` [PATCH v2 5/7] mtd: provide helper to prepare buffers for DMA operations Boris Brezillon
2016-03-30 15:39 ` [PATCH v2 6/7] mtd: nand: sunxi: add support for DMA assisted operations Boris Brezillon
2016-03-30 15:39 ` [PATCH v2 7/7] mtd: nand: sunxi: update DT bindings Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FCAE1B.90206@ti.com \
--to=vigneshr@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox