From: tn@semihalf•com (Tomasz Nowicki)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v8] acpi, apei, arm64: APEI initial support for aarch64.
Date: Mon, 4 Apr 2016 10:32:37 +0200 [thread overview]
Message-ID: <570226A5.4000304@semihalf.com> (raw)
In-Reply-To: <CAKv+Gu-BHhf=aQ6ZP3J=q8T9FRtq-hfzTNvdJ3=HgMt=hVP8nQ@mail.gmail.com>
On 30.03.2016 09:05, Ard Biesheuvel wrote:
> On 29 March 2016 at 09:44, <fu.wei@linaro•org> wrote:
>> From: Tomasz Nowicki <tomasz.nowicki@linaro•org>
>>
>> This commit provides APEI arch-specific bits for aarch64
>>
>> Meanwhile,
>> (1)add a new subfunction "hest_ia32_init" for
>> "acpi_disable_cmcff" which is used by IA-32 Architecture
>> Corrected Machine Check (CMC).
>> (2)move HEST type (ACPI_HEST_TYPE_IA32_CORRECTED_CHECK) checking to
>> a generic place.
>> (3)select EFI when ACPI_APEI is set on ARM64,
>> because arch_apei_get_mem_attribute is using efi_mem_attributes on ARM64.
>
> I think selecting 'EFI' is not the right approach here, especially
> since EFI is implied by ACPI on that architecture. But selecting a
> user configurable option like this is typically not recommended. Why
> doesn't ACPI_APEI depend on ACPI?
It does, ACPI_APEI is subsection of the main ACPI menu option, but I
don't see that ACPI implies EFI in Kconfig.
Also, I agree with Ard, EFI should not be selected conditionally for
ARM64 for ACPI_APEI.
We need EFI only for ARM64 so how about:
+ select HAVE_ACPI_APEI if (ACPI && EFI)
in arch/arm64/Kconfig and leave ACPI_APEI as is?
Regards,
Tomasz
next prev parent reply other threads:[~2016-04-04 8:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 7:44 [PATCH v8] acpi, apei, arm64: APEI initial support for aarch64 fu.wei at linaro.org
2016-03-29 16:35 ` Will Deacon
2016-03-30 17:41 ` Fu Wei
2016-03-30 6:50 ` kbuild test robot
2016-03-30 17:55 ` Fu Wei
2016-03-31 7:52 ` Ard Biesheuvel
2016-03-30 7:05 ` Ard Biesheuvel
2016-03-30 17:40 ` Fu Wei
2016-04-04 8:32 ` Tomasz Nowicki [this message]
2016-04-05 13:49 ` Fu Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570226A5.4000304@semihalf.com \
--to=tn@semihalf$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox