From: adrian.hunter@intel•com (Adrian Hunter)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: mach-imx: sdhci-esdhc-imx: initialize DMA mask
Date: Mon, 11 Apr 2016 13:10:22 +0300 [thread overview]
Message-ID: <570B780E.7090801@intel.com> (raw)
In-Reply-To: <20160411083510.GN10108@pengutronix.de>
On 11/04/16 11:35, Uwe Kleine-K?nig wrote:
> Hello,
>
> I added the people involved in 7b91369b4655 to Cc.
>
> On Mon, Apr 11, 2016 at 10:20:46AM +0200, Alexander Kurz wrote:
>> With commit 7b91369b DMA access got disabled for device drivers with zero
Is that because dma_set_mask_and_coherent() fails?
>
> Please reference commits like:
>
> With commit 7b91369b4655 ("mmc: sdhci: Set DMA mask when adding
> host") DMA access ...
>
>
>> DMA mask property. sdhci-esdhc-imx got blocked from DMA access by this.
>> Hence: initialize the dma mask to enable access again.
>>
>> Signed-off-by: Alexander Kurz <akurz@blala•de>
>> ---
>> arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c b/arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c
>> index a5edd7d..3d039ef 100644
>> --- a/arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c
>> +++ b/arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c
>> @@ -71,6 +71,7 @@ struct platform_device *__init imx_add_sdhci_esdhc_imx(
>> if (!pdata)
>> pdata = &default_esdhc_pdata;
>>
>> - return imx_add_platform_device(data->devid, data->id, res,
>> - ARRAY_SIZE(res), pdata, sizeof(*pdata));
>> + return imx_add_platform_device_dmamask(data->devid, data->id, res,
>> + ARRAY_SIZE(res), pdata, sizeof(*pdata),
>> + DMA_BIT_MASK(32));
>> }
>> --
>> 2.1.4
>>
>>
>
next prev parent reply other threads:[~2016-04-11 10:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 8:20 [PATCH] ARM: mach-imx: sdhci-esdhc-imx: initialize DMA mask Alexander Kurz
2016-04-11 8:35 ` Uwe Kleine-König
2016-04-11 10:10 ` Adrian Hunter [this message]
2016-04-11 16:13 ` Alexander Kurz
2016-04-12 6:05 ` Adrian Hunter
2016-04-12 8:40 ` Russell King - ARM Linux
2016-04-12 9:59 ` Adrian Hunter
2016-04-12 12:25 ` Alexandre Courbot
2016-04-12 15:31 ` Russell King - ARM Linux
2016-04-13 2:02 ` Alexandre Courbot
2016-04-13 8:07 ` Adrian Hunter
2016-04-16 21:48 ` Arnd Bergmann
2016-04-18 6:58 ` Adrian Hunter
2016-04-18 14:33 ` Arnd Bergmann
[not found] ` <57232233.1030702@intel.com>
2016-04-29 8:59 ` Potential issue with SDHCI DMA Adrian Hunter
2016-04-29 9:19 ` Jisheng Zhang
2016-04-12 15:29 ` [PATCH] ARM: mach-imx: sdhci-esdhc-imx: initialize DMA mask Russell King - ARM Linux
2016-04-11 12:46 ` Sergei Shtylyov
2016-04-13 1:38 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570B780E.7090801@intel.com \
--to=adrian.hunter@intel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox