From: wangkefeng.wang@huawei•com (Kefeng Wang)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/2] dt/bindings: Add bindings for hisilicon random number generator
Date: Wed, 13 Apr 2016 13:58:02 +0800 [thread overview]
Message-ID: <570DDFEA.4090103@huawei.com> (raw)
In-Reply-To: <CAL_JsqJv57nX7a89OR8U1=m+MLQKJBCOeuORPWXwGRx_P9XXBQ@mail.gmail.com>
On 2016/4/12 21:54, Rob Herring wrote:
> On Mon, Apr 11, 2016 at 8:16 PM, Kefeng Wang <wangkefeng.wang@huawei•com> wrote:
>>
>>
>> On 2016/4/11 22:43, Rob Herring wrote:
>>> On Thu, Apr 07, 2016 at 04:23:16PM +0800, Kefeng Wang wrote:
>>>> Document the devicetree bindings for the random number generator found
>>>> on Hisilicon Hip04 and Hip05 soc.
>>>>
>>>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei•com>
>>>> ---
>>>> Documentation/devicetree/bindings/rng/hisi-rng.txt | 12 ++++++++++++
>>>> 1 file changed, 12 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/rng/hisi-rng.txt
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/rng/hisi-rng.txt b/Documentation/devicetree/bindings/rng/hisi-rng.txt
>>>> new file mode 100644
>>>> index 0000000..72efcc1
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/rng/hisi-rng.txt
>>>> @@ -0,0 +1,12 @@
>>>> +Hisilicon Random Number Generator
>>>> +
>>>> +Required properties:
>>>> +- compatible : Should be "hisilicon,rng"
>>>> +- reg : Offset and length of the register set of this block
>>>> +
>>>> +Example:
>>>> +
>>>> +rng at d1010000 {
>>>> + compatible = "hisilicon,rng";
>>>
>>> This still needs SoC specific compatible strings.
>>
>> It is used by Hip04/Hip05 at lease, but for new SoC, like Hip06, it maybe different,
>> using single Soc prefix is not proper, how about hisilicon,rng-v1, or add two compatible
>> hisilicon,hip04-rng and hisilicon,hip05-rng? What's your option?
>
> It is perfectly fine to include hisilicon,hip04-rng string for hip05
> and later if the block is the same. You should still have both strings
> (the original and current SoC) in case there is some issue or
> difference found.
>
> Unless there is a real IP version defined, you should avoid made up
> version numbers.
>
Ok, will add both of them in v4, thanks.
> Rob
>
> .
>
next prev parent reply other threads:[~2016-04-13 5:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 8:23 [PATCH v2 0/2] Add Hisilicon Random Number Generator(RNG) support Kefeng Wang
2016-04-07 8:23 ` [PATCH v2 1/2] dt/bindings: Add bindings for hisilicon random number generator Kefeng Wang
2016-04-11 14:43 ` Rob Herring
2016-04-12 1:16 ` Kefeng Wang
2016-04-12 13:54 ` Rob Herring
2016-04-13 5:58 ` Kefeng Wang [this message]
2016-04-07 8:23 ` [PATCH v2 2/2] hwrng: hisi: Add support for Hisilicon SoC RNG Kefeng Wang
2016-04-07 14:55 ` Mathieu Poirier
2016-04-08 2:03 ` Kefeng Wang
2016-04-08 14:35 ` Mathieu Poirier
2016-04-11 1:36 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570DDFEA.4090103@huawei.com \
--to=wangkefeng.wang@huawei$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox