From: mbrugger@suse•com (Matthias Brugger)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/6] staging: fsl-mc: Use platform_msi_* infrastructure
Date: Wed, 13 Apr 2016 13:23:24 +0200 [thread overview]
Message-ID: <570E2C2C.6090900@suse.com> (raw)
In-Reply-To: <570E25DD.9070106@arm.com>
On 13/04/16 12:56, Marc Zyngier wrote:
> On 13/04/16 11:30, Matthias Brugger wrote:
>> From: Matthias Brugger <matthias.bgg@gmail•com>
>>
>> The fsl-mc driver can't be build as a module because it uses msi_*
>> functions directly. Port the driver to use the platform_msi_*
>> infrastructure instead, to allow it to be build as a module.
>>
>> Signed-off-by: Matthias Brugger <mbrugger@suse•com>
>> ---
>> .../staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 5 +-
>> drivers/staging/fsl-mc/bus/mc-allocator.c | 9 +-
>> drivers/staging/fsl-mc/bus/mc-msi.c | 169 +--------------------
>> drivers/staging/fsl-mc/include/mc-sys.h | 3 +
>> 4 files changed, 14 insertions(+), 172 deletions(-)
>>
>> diff --git a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c
>> index 720e2b0..0eecb7e 100644
>> --- a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c
>> +++ b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c
>> @@ -25,7 +25,6 @@ static struct irq_chip its_msi_irq_chip = {
>> .irq_mask = irq_chip_mask_parent,
>> .irq_unmask = irq_chip_unmask_parent,
>> .irq_eoi = irq_chip_eoi_parent,
>> - .irq_set_affinity = msi_domain_set_affinity
>> };
>>
>> static int its_fsl_mc_msi_prepare(struct irq_domain *msi_domain,
>> @@ -86,7 +85,7 @@ int __init its_fsl_mc_msi_init(void)
>> continue;
>> }
>>
>> - mc_msi_domain = fsl_mc_msi_create_irq_domain(
>> + mc_msi_domain = platform_msi_create_irq_domain(
>> of_node_to_fwnode(np),
>> &its_fsl_mc_msi_domain_info,
>> parent);
>
> What? We are already creating a platform MSI domain for the ITS. How is
> that going to work? If you want to convert this set of drivers to
> platform ITS, fine. But you can't randomly hack in the ITS code and pray
> for things not to fall apart.
>
From what I see, the difference between irq-gic-v3-its-fsl-mc-msi and
the irq-gic-v3-its-platform-msi is the way ITS specific DeviceID is
created in msi_prepare.
German, is there a reason why you use the ICID read from the DPRC as dev_id?
Regards,
Matthias
next prev parent reply other threads:[~2016-04-13 11:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 10:30 staging: fsl-mc: Convert to use platform_msi infrastrucutre Matthias Brugger
2016-04-13 10:30 ` [PATCH 1/6] of/irq: Export of_msi_get_domain Matthias Brugger
2016-04-13 12:32 ` Rob Herring
2016-04-13 10:30 ` [PATCH 2/6] base: Export platform_msi_create_irq_domain Matthias Brugger
2016-04-13 10:30 ` [PATCH 3/6] genirq/msi: Export msi_get_domain_info Matthias Brugger
2016-04-13 10:30 ` [PATCH 4/6] staging: fsl-mc: Use platform_msi_* infrastructure Matthias Brugger
2016-04-13 10:56 ` Marc Zyngier
2016-04-13 11:23 ` Matthias Brugger [this message]
2016-04-13 12:08 ` Marc Zyngier
2016-04-13 14:57 ` Stuart Yoder
2016-04-13 10:30 ` [PATCH 5/6] staging: fsl-mc: Clean up of irq_chip callbacks Matthias Brugger
2016-04-13 10:30 ` [PATCH 6/6] Revert "staging: fsl-mc: Do not allow building as a module" Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570E2C2C.6090900@suse.com \
--to=mbrugger@suse$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox