Subject: [PATCH] [media] exynos-gsc: remove an always false condition

From: [email-masked] (Sylwester Nawrocki)
Date: Thu, 14 Apr 2016 11:05:17 +0200

On 04/13/2016 09:32 PM, Mauro Carvalho Chehab wrote:
> As reported by smatch:
> drivers/media/platform/exynos-gsc/gsc-core.c:1073 gsc_probe() warn: impossible condition '(gsc->id < 0) => (0-65535 < 0)'
> drivers/media/platform/exynos-gsc/gsc-core.c: In function 'gsc_probe':
> drivers/media/platform/exynos-gsc/gsc-core.c:1073:51: warning: comparison is always false due to limited range of data type [-Wtype-limits]
>   if (gsc->id >= drv_data->num_entities || gsc->id < 0) {
>                                                    ^
> 
> gsc->id is an u16, so it can never be a negative number. So,
> remove the always false condition.
> 
> Fixes: c1ac057173ba "[media] exynos-gsc: remove non-device-tree init code"
> Cc: Sylwester Nawrocki <[email-masked]>
> Signed-off-by: Mauro Carvalho Chehab <[email-masked]>

Thanks for fixing this.
Acked-by: Sylwester Nawrocki <[email-masked]>

-- 
Regards,
Sylwester