From: stefan.wahren@i2se•com (Stefan Wahren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH RFT 4/5] iio: mxs-lradc: disable only mapped channels in mxs_lradc_hw_stop
Date: Mon, 18 Apr 2016 08:36:48 +0200 [thread overview]
Message-ID: <57148080.4010200@i2se.com> (raw)
In-Reply-To: <571369AA.8060106@kernel.org>
Hi Jonathan,
Am 17.04.2016 um 12:47 schrieb Jonathan Cameron:
> On 14/04/16 16:48, Stefan Wahren wrote:
>> Disabling of the touchscreen IRQs is already done in
>> mxs_lradc_disable_ts. There is no need to disable them in
>> mxs_lradc_hw_stop again.
> We could do with a little more documentation in the driver on
> which bits in this register are doing what.
>
> The disable_ts deals with bits 22-24...
> The only other bit I think is ever used by the driver currently is
> 16 (channel 0).
>
> So whilst this change probably works, I'm not sure of the logic behind it.
> As far as I can tell your new clear is fine but in reality you could
> just clear (0x3f << 16) and get the same result (which would be clearer
> to my mind).
>
> The key think here is that we don't support the higher bits on i.mx28
> yet... Which are for button detection and threshold detection.
>
> Have I understood this correctly?
Yes, you are. I've have looked to long in the reference manual instead
of the code.
I've missed the point that virtual channel 6 and 7 are used in case of a
connected touchscreen.
I should use the member buffer_vchans for masking the enable IRQs.
Regards
Stefan
>
> Jonathan
> So we only need to care of the
next prev parent reply other threads:[~2016-04-18 6:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 15:48 [PATCH RFT 0/5] iio: mxs-lradc: fix leak and implement PM ops Stefan Wahren
2016-04-14 15:48 ` [PATCH RFT 1/5] iio: mxs-lradc: fix memory leak Stefan Wahren
2016-04-14 20:01 ` Marek Vasut
2016-04-17 10:08 ` Jonathan Cameron
2016-04-18 17:16 ` Marek Vasut
2016-04-19 6:33 ` Stefan Wahren
2016-04-19 10:32 ` Marek Vasut
2016-04-19 13:37 ` Stefan Wahren
2016-04-19 18:58 ` Jonathan Cameron
2016-04-19 19:29 ` Marek Vasut
2016-04-18 6:19 ` Stefan Wahren
2016-04-18 10:45 ` Marek Vasut
2016-04-14 15:48 ` [PATCH RFT 2/5] iio: mxs-lradc: move TS config into suitable function Stefan Wahren
2016-04-14 20:01 ` Marek Vasut
2016-04-17 10:13 ` Jonathan Cameron
2016-04-17 12:19 ` Torokhov
2016-04-18 6:26 ` Stefan Wahren
2016-04-14 15:48 ` [PATCH RFT 3/5] iio: mxs-lradc: move STMP reset out of ADC init Stefan Wahren
2016-04-15 6:48 ` Juergen Borleis
2016-04-15 10:12 ` Marek Vasut
2016-04-17 10:24 ` Jonathan Cameron
2016-04-14 15:48 ` [PATCH RFT 4/5] iio: mxs-lradc: disable only mapped channels in mxs_lradc_hw_stop Stefan Wahren
2016-04-17 10:47 ` Jonathan Cameron
2016-04-18 6:36 ` Stefan Wahren [this message]
2016-04-14 15:48 ` [PATCH RFT 5/5] iio: mxs-lradc: implement suspend/resume support Stefan Wahren
2016-04-17 10:48 ` Jonathan Cameron
2016-04-14 19:55 ` [PATCH RFT 0/5] iio: mxs-lradc: fix leak and implement PM ops Marek Vasut
2016-04-18 6:17 ` Stefan Wahren
2016-04-18 10:44 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57148080.4010200@i2se.com \
--to=stefan.wahren@i2se$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox