From: james.morse@arm•com (James Morse)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/3] arm64: mm: make pr_cont() per line in Virtual kernel memory layout
Date: Mon, 18 Apr 2016 14:13:15 +0100 [thread overview]
Message-ID: <5714DD6B.6050108@arm.com> (raw)
In-Reply-To: <CAKv+Gu-bOjOYRWVV7NfSfOJy9AtdKNmgrARdRHTT=HsGWVKoYA@mail.gmail.com>
Hi Ard,
On 18/04/16 12:21, Ard Biesheuvel wrote:
> On 18 April 2016 at 13:16, James Morse <james.morse@arm•com> wrote:
>> On 18/04/16 04:09, Kefeng Wang wrote:
>>> Each line with single pr_cont() in Virtual kernel memory layout,
>>> or the dump of the kernel memory layout in dmesg is not aligned
>>> when PRINTK_TIME enabled, due to the missing time stamps.
>>
>> Looks good to me, but I can't reproduce the miss-aligned output on v4.6-rc4, I get:
>>> [ 0.000000] .text : 0xffffff8008080000 - 0xffffff8008887000 ( 8220 KB)
>>> [ 0.000000] .rodata : 0xffffff8008887000 - 0xffffff8008bdc000 ( 3412 KB)
>>> [ 0.000000] .init : 0xffffff8008bdc000 - 0xffffff8008cc3000 ( 924 KB)
>>> [ 0.000000] .data : 0xffffff8008cc3000 - 0xffffff8008dd7200 ( 1105 KB)
>>
>> without this patch, but it evidently happens for you. Do you have any special
>> build options or kernel version? I'd like to understand if there is some
>> kconfig/earlycon option that affects this!
>>
>
> Interestingly, for me it only occurs when running dmesg, and not when
> observing the output from the console directly.
Hmmm, after some more digging: dmesg on Ubuntu 15.04 miss-aligns this, but
Ubuntu 14.04 doesn't....
Regardless, the patch fixes it, (and it looks the same on both ubuntu versions):
Tested-by: James Morse <james.morse@arm•com>
>From the comment above 'pr_cont()' in include/linux/printk.h:
> * Like KERN_CONT, pr_cont() should only be used when continuing
> * a line with no newline ('\n') enclosed. Otherwise it defaults
> * back to KERN_DEFAULT.
arm64 is probably confusing dmesg with its use of pr_cont("...\n").
Thanks,
James
15.04: util-linux 2.25.2-4ubuntu3
14.04: util-linux 2.20.1-5.1ubuntu20
next prev parent reply other threads:[~2016-04-18 13:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 7:49 [PATCH] arm64: mm: Enhance Virtual kernel memory layout Kefeng Wang
2016-04-13 9:26 ` James Morse
2016-04-14 6:57 ` Kefeng Wang
2016-04-15 17:20 ` Will Deacon
2016-04-18 2:05 ` Kefeng Wang
2016-04-18 3:09 ` [PATCH v2 0/3] " Kefeng Wang
2016-04-18 3:09 ` [PATCH v2 1/3] arm64: mm: make pr_cont() per line in " Kefeng Wang
2016-04-18 11:16 ` James Morse
2016-04-18 11:21 ` Ard Biesheuvel
2016-04-18 13:13 ` James Morse [this message]
2016-04-19 5:58 ` Kefeng Wang
2016-04-18 3:09 ` [PATCH v2 2/3] arm64: mm: Show bss segment in " Kefeng Wang
2016-04-18 11:14 ` James Morse
2016-04-18 3:09 ` [PATCH v2 3/3] arm64: mm: Restrictive printing for modules and PCI I/O in " Kefeng Wang
2016-04-18 11:15 ` James Morse
2016-04-19 7:08 ` Kefeng Wang
2016-05-12 12:16 ` [PATCH v3 0/2] arm64: mm: Enhance Virtual kernel " Kefeng Wang
2016-05-12 12:16 ` [PATCH v3 1/2] arm64: mm: make pr_cont() per line in " Kefeng Wang
2016-05-12 12:16 ` [PATCH v3 2/2] arm64: mm: Show bss segment in " Kefeng Wang
2016-05-12 13:36 ` [PATCH v3 0/2] arm64: mm: Enhance Virtual " Will Deacon
2016-05-13 1:21 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5714DD6B.6050108@arm.com \
--to=james.morse@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox