From: narmstrong@baylibre•com (Neil Armstrong)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks
Date: Wed, 20 Apr 2016 10:44:01 +0200 [thread overview]
Message-ID: <57174151.8040806@baylibre.com> (raw)
In-Reply-To: <20160419212944.GF15324@codeaurora.org>
Hi Stephen,
On 04/19/2016 11:29 PM, Stephen Boyd wrote:
> On 04/18, Neil Armstrong wrote:
>> +
>> +static int oxnas_stdclk_probe(struct platform_device *pdev)
>> +{
>> + struct device_node *np = pdev->dev.of_node;
>> + struct clk_oxnas_data *clk_oxnas;
>> + struct regmap *regmap;
>> + int i;
>> +
>> + clk_oxnas = devm_kzalloc(&pdev->dev, sizeof(*clk_oxnas), GFP_KERNEL);
>> + if (!clk_oxnas)
>> + return -ENOMEM;
>> +
>> + regmap = syscon_node_to_regmap(of_get_parent(np));
>> + if (!regmap) {
>> + dev_err(&pdev->dev, "failed to have parent regmap\n");
>> + return -EINVAL;
>> + }
>> +
>> + for (i = 0; i < ARRAY_SIZE(clk_oxnas_init); i++) {
>> + struct clk_oxnas *_clk;
>> +
>> + if (!clk_oxnas_init[i].clk_init)
>> + continue;
>
> New design is fine, really it's up to you, but then this check
> isn't needed anymore, right?
>
it's not needed for sure, but do I need to send a v3 to remove this ?
Neil
next prev parent reply other threads:[~2016-04-20 8:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 10:01 [PATCH v2 0/2] clk: Add Oxford Semiconductor OXNAS Clocks support Neil Armstrong
2016-04-18 10:01 ` [PATCH v2 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks Neil Armstrong
2016-04-19 21:29 ` Stephen Boyd
2016-04-20 8:44 ` Neil Armstrong [this message]
2016-04-20 18:40 ` Stephen Boyd
2016-04-21 21:20 ` Stephen Boyd
2016-04-18 10:01 ` [PATCH v2 2/2] dt-bindings: Add Oxford Semiconductor OXNAS Standard Clocks bindings Neil Armstrong
2016-04-21 21:20 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57174151.8040806@baylibre.com \
--to=narmstrong@baylibre$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox