From: vz@mleia•com (Vladimir Zapolskiy)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] gpio: lpc32xx: disable broken to_irq support
Date: Wed, 11 May 2016 22:58:14 +0300 [thread overview]
Message-ID: <57338ED6.3090001@mleia.com> (raw)
In-Reply-To: <1462988400-21738-1-git-send-email-slemieux.tyco@gmail.com>
Hi Sylvain,
On 11.05.2016 20:40, Sylvain Lemieux wrote:
> From: Sylvain Lemieux <slemieux@tycoint•com>
>
> The "to_irq" functionality is broken inside this driver since commit
> 76ba59f8366f ("genirq: Add irq_domain-aware core IRQ handler").
>
> The addition of the new lpc32xx irqchip driver in 4.7, fixed the
> lpc32xx platform interrupt issue.
>
> When switching to the new lpc32xx irqchip driver, a warning appear
> in the lpc32xx gpio driver: warning: "NR_IRQS" redefined.
>
> To remove this warning (temporary solution), this patch
> disables the broken "to_irq" mapping functionality support.
>
> Signed-off-by: Sylvain Lemieux <slemieux@tycoint•com>
> ---
> Note:
> * For details on the lpc32xx irqchip patch, refer to:
> http://thread.gmane.org/gmane.linux.drivers.devicetree/165620
>
> * The final solution is to replace the existing lpc32xx gpio driver.
> This work is currently in progress; refer to the following URL:
> http://thread.gmane.org/gmane.linux.drivers.devicetree/144696
>
> drivers/gpio/gpio-lpc32xx.c | 48 +--------------------------------------------
> 1 file changed, 1 insertion(+), 47 deletions(-)
>
the change looks good to me.
Probably all lpc32xx_gpio_to_irq* functions can be removed along with .to_irq
callback assignments, but it is up to you.
Acked-by: Vladimir Zapolskiy <vz@mleia•com>
--
With best wishes,
Vladimir
next prev parent reply other threads:[~2016-05-11 19:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 17:40 [PATCH] gpio: lpc32xx: disable broken to_irq support Sylvain Lemieux
2016-05-11 19:58 ` Vladimir Zapolskiy [this message]
2016-05-24 10:57 ` Linus Walleij
2016-05-24 12:54 ` Sylvain Lemieux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57338ED6.3090001@mleia.com \
--to=vz@mleia$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox