From: robin.murphy@arm•com (Robin Murphy)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] drm: mediatek: remove IOMMU_DMA select
Date: Thu, 12 May 2016 10:24:02 +0100 [thread overview]
Message-ID: <57344BB2.8020608@arm.com> (raw)
In-Reply-To: <1462997501-982363-1-git-send-email-arnd@arndb.de>
On 11/05/16 21:11, Arnd Bergmann wrote:
> We get a harmless build warning when trying to use the mediatek
> DRM driver with IOMMU support disabled:
>
> warning: (DRM_MEDIATEK) selects IOMMU_DMA which has unmet direct dependencies (IOMMU_SUPPORT)
>
> However, the IOMMU_DMA symbol is not meant to be used by drivers
> at all, and this driver doesn't seem to have a strict dependency
> on it other than using the mediatek IOMMU driver that does.
>
> Since we also want to be able to do compile tests with the
> driver on other platforms, the IOMMU_DMA symbol should not
> be selected here.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
> ---
> If someone has a better explanation about why the 'select' is here,
> let me know, it certainly seems out of place.
Ack - it's neither an IOMMU driver nor a DMA API implementation, so it
has no business with IOMMU_DMA. If there's an IOMMU dependency in
general it should be on MTK_IOMMU, not underlying implementation details.
Robin.
> drivers/gpu/drm/mediatek/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
> index 0c06a69d7f04..545973f6b743 100644
> --- a/drivers/gpu/drm/mediatek/Kconfig
> +++ b/drivers/gpu/drm/mediatek/Kconfig
> @@ -7,7 +7,6 @@ config DRM_MEDIATEK
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> select DRM_PANEL
> - select IOMMU_DMA
> select MEMORY
> select MTK_SMI
> help
>
next prev parent reply other threads:[~2016-05-12 9:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 16:01 More build fixes for omapdrm in current -next Arnd Bergmann
2016-05-11 16:01 ` [PATCH 1/3] drm/omap: include linux/seq_file.h where needed Arnd Bergmann
2016-05-11 16:01 ` [PATCH 2/3] drm/omap: include linux/of.h " Arnd Bergmann
2016-05-11 16:05 ` [PATCH 3/3] drm/omap: include gpio/consumer.h " Arnd Bergmann
2016-05-11 20:11 ` [PATCH] drm: mediatek: remove IOMMU_DMA select Arnd Bergmann
2016-05-11 20:15 ` Arnd Bergmann
2016-06-21 13:19 ` Thierry Reding
2016-05-12 9:24 ` Robin Murphy [this message]
2016-05-12 10:46 ` Philipp Zabel
2016-05-17 8:07 ` More build fixes for omapdrm in current -next Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57344BB2.8020608@arm.com \
--to=robin.murphy@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox