From: patrice.chotard@st•com (Patrice Chotard)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] pinctrl: stm32: fix debugfs format string
Date: Tue, 17 May 2016 09:43:18 +0200 [thread overview]
Message-ID: <573ACB96.6030808@st.com> (raw)
In-Reply-To: <1463147643-568615-1-git-send-email-arnd@arndb.de>
Hi Arnd
I have already send a fix for this on the mailing list on 12th may
([PATCH 0/2] pinctrl: stm32: .pin_config_dbg_show fixes).
I don't know if Linus will merged it on his pinctrl branch.
Sorry
Patrice
On 05/13/2016 03:53 PM, Arnd Bergmann wrote:
> The newly added stm32_pconf_dbg_show function has an incorrect format
> string that does not match the arguments, as reported by the gcc warning:
>
> drivers/pinctrl/stm32/pinctrl-stm32.c: In function 'stm32_pconf_dbg_show':
> drivers/pinctrl/stm32/pinctrl-stm32.c:797:17: error: too many arguments for format [-Werror=format-extra-args]
>
> This changes the format string in a way that gets rid of the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
> Fixes: 3beed93c1617 ("pinctrl: stm32: Implement .pin_config_dbg_show()")
> ---
> I could not find a documentation for the debugfs format, so no
> idea if this is the intended format.
> ---
> drivers/pinctrl/stm32/pinctrl-stm32.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c
> index e51c1cf5270b..4ffbe9551299 100644
> --- a/drivers/pinctrl/stm32/pinctrl-stm32.c
> +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c
> @@ -794,7 +794,7 @@ static void stm32_pconf_dbg_show(struct pinctrl_dev *pctldev,
> case 2:
> drive = stm32_pconf_get_driving(bank, offset);
> speed = stm32_pconf_get_speed(bank, offset);
> - seq_printf(s, "%d - %s -%s", alt,
> + seq_printf(s, "%d - %s - %s - %s %s ", alt,
> drive ? "open drain" : "push pull",
> biasing[bias],
> speeds[speed], "speed");
prev parent reply other threads:[~2016-05-17 7:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 13:53 [PATCH] pinctrl: stm32: fix debugfs format string Arnd Bergmann
2016-05-17 7:43 ` Patrice Chotard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573ACB96.6030808@st.com \
--to=patrice.chotard@st$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox