From: ddaney@caviumnetworks•com (David Daney)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/1] net: thunderx: avoid null pointer dereference
Date: Tue, 17 May 2016 13:21:13 -0700 [thread overview]
Message-ID: <573B7D39.9050305@caviumnetworks.com> (raw)
In-Reply-To: <1463514038-9008-1-git-send-email-xypron.glpk@gmx.de>
On 05/17/2016 12:40 PM, Heinrich Schuchardt wrote:
> In function bgx_lmac_handler only use a member of
> lmac after checking it is not null.
>
Were you seeing and actual OOPs, or is this only a theoretical problem
flagged by some sort of static code checker?
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx•de>
In any event, it seems sane to make this change, so:
Acked-by: David Daney <david.daney@cavium•com>
> ---
> drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> index d20539a..3ed2198 100644
> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> @@ -274,12 +274,14 @@ static void bgx_sgmii_change_link_state(struct lmac *lmac)
> static void bgx_lmac_handler(struct net_device *netdev)
> {
> struct lmac *lmac = container_of(netdev, struct lmac, netdev);
> - struct phy_device *phydev = lmac->phydev;
> + struct phy_device *phydev;
> int link_changed = 0;
>
> if (!lmac)
> return;
>
> + phydev = lmac->phydev;
> +
> if (!phydev->link && lmac->last_link)
> link_changed = -1;
>
>
next prev parent reply other threads:[~2016-05-17 20:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 19:40 [PATCH 1/1] net: thunderx: avoid null pointer dereference Heinrich Schuchardt
2016-05-17 20:21 ` David Daney [this message]
2016-05-17 21:37 ` Heinrich Schuchardt
2016-05-19 18:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573B7D39.9050305@caviumnetworks.com \
--to=ddaney@caviumnetworks$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox