From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] arm64: tegra: Fix CPU compatible string for Tegra132
Date: Wed, 25 May 2016 09:42:28 -0600 [thread overview]
Message-ID: <5745C7E4.2050908@wwwdotorg.org> (raw)
In-Reply-To: <574509E7.4030208@nvidia.com>
On 05/24/2016 08:11 PM, Joseph Lo wrote:
> On 05/23/2016 03:42 PM, Joseph Lo wrote:
>> As per commit f634da375fc96 ("Documentation: DT bindings: add nvidia,
>> tegra132-denver compatible string"), fixing the CPU compatible string for
>> Tegra132 to match the binding document currently.
>>
>> Signed-off-by: Joseph Lo <josephl@nvidia•com>
>> ---
>> arch/arm64/boot/dts/nvidia/tegra132.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra132.dtsi
>> b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
>> index 2013f8916084..7b1cdc029de3 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra132.dtsi
>> +++ b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
>> @@ -964,13 +964,13 @@
>>
>> cpu at 0 {
>> device_type = "cpu";
>> - compatible = "nvidia,denver", "arm,armv8";
>> + compatible = "nvidia,tegra132-denver", "arm,armv8";
>
> Hi Stephen, Thierry,
>
> Should we fix this or fix the compatible string in the binding document
> as just "nvidia,denver" to represent all the Devner CPU revisions just
> like some other CPUs did? e.g. arm,cortex-a57, which represents all the
> A57 revisions.
I would expect compatible to be:
compatible = "nvidia,tegra132-denver", "nvidia,denver", "arm,armv8";
The "nvidia,denver" entry is already present, and hence probably
shouldn't be removed. It can represent "Denver 1.0". We should add the
T132 entry to indicate the specific implementation. Admittedly right now
there's a 1:1 relation between SoC and Denver version. Either/both of
those could in theory be required to trigger specific bug-fixes/WARs.
For later chips which have a different Denver version, I'd expect to see
something like:
compatible = "nvidia,tegraNNN-denver", "nvidia,denverMMM", "arm,armv8";
... where NNN is the SoC version/name and MMM is the Denver version.
There could be extra entries in the property if the new versions are
backwards-compatible with old versions.
next prev parent reply other threads:[~2016-05-25 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 7:42 [PATCH] arm64: tegra: Fix CPU compatible string for Tegra132 Joseph Lo
2016-05-25 2:11 ` Joseph Lo
2016-05-25 15:42 ` Stephen Warren [this message]
2016-05-26 9:29 ` Joseph Lo
2016-05-26 16:29 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5745C7E4.2050908@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox