From: nm@ti•com (Nishanth Menon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 0/2] arm: dra7: Add i2c6 instance hwmod and dt entries
Date: Wed, 25 May 2016 11:09:50 -0500 [thread overview]
Message-ID: <5745CE4E.3020903@ti.com> (raw)
In-Reply-To: <20160525125341.10044-1-rk@ti.com>
On 05/25/2016 07:53 AM, Ravikumar Kattekola wrote:
> DRA72x devices have a sixth i2c ocntroller instance.
> Following patches add the required hwmod structure and
> device tree nodes.
>
> Reference doc: DRA72x TRM [ SPRUHP2Q ]
>
> Tested on :
> DRA72x Rev B EVM
>
> Ravikumar Kattekola (2):
> arm: dra7: Add hwmod entry for i2c6
> dts: dra7: Add device tree node for i2c6
>
> arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
> 2 files changed, 34 insertions(+)
>
NAK. reasoning:
a) i2c6 is a custom IP integration with completely non-standard
dependencies with cross device dependencies for pretty much a specific
usecase -> usage is pretty much limited for generic support - the
decision is NOT to support this instance in Linux kernel - internal
discussion forwarded to developer.
b) the patches themselves are wrong -> it applies to DRA72x not
generic DRA7x platform
c) patches themselves are in the wrong format (wrong subject line etc).
d) patches don't handle the SoC internal device dependencies either ->
in short will not function in a generic solution for all variations of
platforms.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2016-05-25 16:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 12:53 [PATCH 0/2] arm: dra7: Add i2c6 instance hwmod and dt entries Ravikumar Kattekola
2016-05-25 12:53 ` [PATCH 1/2] arm: dra7: Add hwmod entry for i2c6 Ravikumar Kattekola
2016-05-25 16:10 ` Nishanth Menon
2016-05-26 3:55 ` Lokesh Vutla
2016-05-25 12:53 ` [PATCH 2/2] dts: dra7: Add device tree node " Ravikumar Kattekola
2016-05-25 16:11 ` Nishanth Menon
2016-05-25 16:09 ` Nishanth Menon [this message]
2016-05-26 5:47 ` [PATCH 0/2] arm: dra7: Add i2c6 instance hwmod and dt entries Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5745CE4E.3020903@ti.com \
--to=nm@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox