From: k.kozlowski@samsung•com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC v2] dma-mapping: Use unsigned long for dma_attrs
Date: Wed, 01 Jun 2016 08:08:11 +0200 [thread overview]
Message-ID: <574E7BCB.6040505@samsung.com> (raw)
In-Reply-To: <20160531181533.GD11300@char.us.oracle.com>
On 05/31/2016 08:15 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, May 30, 2016 at 01:54:06PM +0200, Krzysztof Kozlowski wrote:
>> The dma-mapping core and the implementations do not change the
>> DMA attributes passed by pointer. Thus the pointer can point to const
>> data. However the attributes do not have to be a bitfield. Instead
>> unsigned long will do fine:
>>
>> 1. This is just simpler. Both in terms of reading the code and setting
>> attributes. Instead of initializing local attributes on the stack and
>> passing pointer to it to dma_set_attr(), just set the bits.
>>
>> 2. It brings safeness and checking for const correctness because the
>> attributes are passed by value.
>
>
> .. why not go the next step a do an enum? Perhaps that should be mentioned
> as part of the description?
These are additive flags so to me this would look a little bit weird:
enum dma_attr {
DMA_ATTR_WRITE_BARRIER = 0x1,
DMA_ATTR_WEAK_ORDERING = 0x2,
DMA_ATTR_WRITE_COMBINE = 0x4,
DMA_ATTR_NON_CONSISTENT = 0x8,
...
}
It doesn't really look like enumeration.
Best regards,
Krzysztof
prev parent reply other threads:[~2016-06-01 6:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 11:54 [RFC v2] Change dma_attrs from bitfield to unsigned long Krzysztof Kozlowski
2016-05-30 11:54 ` [RFC v2] dma-mapping: Use unsigned long for dma_attrs Krzysztof Kozlowski
2016-05-31 17:04 ` Christoph Hellwig
2016-06-01 5:36 ` Krzysztof Kozlowski
2016-06-01 7:51 ` Christoph Hellwig
2016-05-31 18:15 ` Konrad Rzeszutek Wilk
2016-06-01 6:08 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574E7BCB.6040505@samsung.com \
--to=k.kozlowski@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox