From: james.morse@arm•com (James Morse)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v17 02/13] arm64: Add cpus_are_stuck_in_kernel
Date: Thu, 09 Jun 2016 15:51:48 +0100 [thread overview]
Message-ID: <57598284.3090108@arm.com> (raw)
In-Reply-To: <d4f8c7961adc4b0afe733306fbc21e5bb7c8f6ee.1464974516.git.geoff@infradead.org>
Hi Geoff,
On 03/06/16 19:13, Geoff Levand wrote:
> From: James Morse <james.morse@arm•com>
>
> kernel/smp.c has a fancy counter that keeps track of the number of CPUs
> it marked as not-present and left in cpu_park_loop(). If there are any
> CPUs spinning in here, kexec will release them once the memory is re-used
> by the new kernel.
>
> We can't return an error once we reach machine_kexec(), so as a sanity check
> we forbid kexec images to be loaded if there are already cpus stuck in the
> kernel, or we have multiple cpus and no way of disabling them.
>
> Signed-off-by: James Morse <james.morse@arm•com>
> [Split off from a larger patch]
> Signed-off-by: Geoff Levand <geoff@infradead•org>
Post-split, the second paragraph of the commit message is out of place, and
doesn't describe what the patch does. Can I suggest replacing it with:
> Provide a function to expose whether this counter is non-zero, so we can use >
this when loading a new kexec image, and when calling machine_kexec().
Thanks,
James
next prev parent reply other threads:[~2016-06-09 14:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 18:13 [PATCH v17 00/13] arm64 kexec kernel patches Geoff Levand
2016-06-03 18:13 ` [PATCH v17 01/13] arm64: Add back cpu reset routines Geoff Levand
2016-06-09 14:50 ` James Morse
2016-06-09 18:25 ` Geoff Levand
2016-06-03 18:13 ` [PATCH v17 02/13] arm64: Add cpus_are_stuck_in_kernel Geoff Levand
2016-06-09 14:51 ` James Morse [this message]
2016-06-09 18:38 ` Geoff Levand
2016-06-03 18:13 ` [PATCH v17 07/13] arm64: limit memory regions based on DT property, usable-memory Geoff Levand
2016-06-03 18:13 ` [PATCH v17 06/13] arm64: kdump: reserve memory for crash dump kernel Geoff Levand
2016-06-03 18:13 ` [PATCH v17 03/13] arm64/kexec: Add core kexec support Geoff Levand
2016-06-03 18:13 ` [PATCH v17 05/13] arm64/kexec: Enable kexec in the arm64 defconfig Geoff Levand
2016-06-03 18:13 ` [PATCH v17 08/13] arm64: kdump: implement machine_crash_shutdown() Geoff Levand
2016-06-03 18:13 ` [PATCH v17 10/13] arm64: kdump: add VMCOREINFO for user-space coredump tools Geoff Levand
2016-06-09 15:09 ` Suzuki K Poulose
2016-06-09 15:17 ` Suzuki K Poulose
2016-06-09 23:19 ` AKASHI Takahiro
2016-06-03 18:13 ` [PATCH v17 11/13] arm64: kdump: enable kdump in the arm64 defconfig Geoff Levand
2016-06-03 18:13 ` [PATCH v17 09/13] arm64: kdump: add kdump support Geoff Levand
2016-06-03 18:13 ` [PATCH v17 04/13] arm64/kexec: Add pr_debug output Geoff Levand
2016-06-03 18:13 ` [PATCH v17 12/13] arm64: kdump: update a kernel doc Geoff Levand
2016-06-03 18:13 ` [PATCH v17 13/13] Documentation: dt: usable-memory and elfcorehdr nodes for arm64 kexec Geoff Levand
2016-06-07 1:36 ` [PATCH v17 00/13] arm64 kexec kernel patches AKASHI Takahiro
2016-06-08 6:31 ` AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57598284.3090108@arm.com \
--to=james.morse@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox